[GitHub] [tvm] Lunderberg commented on a diff in pull request #11289: [Schedule] Allowed typing.Tuple in tir.schedule._type_checker

[GitBox <gi...@apache.org>]

Lunderberg commented on code in PR #11289:
URL: https://github.com/apache/tvm/pull/11289#discussion_r871756366


##########
python/tvm/tir/schedule/_type_checker.py:
##########
@@ -134,14 +169,25 @@ def _type_check_atomic(v: Any, name: str, type_: Any) -> Optional[str]:
         return None if isinstance(v, type_) else _type_check_err(v, name, type_)
 
     def _type_check_list(v: List[Any], name: str, type_: Any) -> Optional[str]:
-        if not isinstance(v, (list, tuple)):
+        if not isinstance(v, list):

Review Comment:
   Got it.  I wasn't sure if that was intended behavior, or was an early version of supporting tuples.  It makes sense for it to be intended behavior, since both are converted to `Array<T>` by the ffi.  I will revert this line.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org