You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/23 20:22:40 UTC

[GitHub] [beam] iemejia commented on pull request #11454: [BEAM-8871] Support trySplit for ByteKeyRangeTracker

iemejia commented on pull request #11454:
URL: https://github.com/apache/beam/pull/11454#issuecomment-618645769


   (Sorry for adding this but cannot find a better moment ot ask). Curious question related to fractional splits (but not to this PR). Would testing trySplit for a RestrictionTracker would be enough to test that a SDF based IO that uses this kind of Restriction supports DWR correctly?
   
   I am asking because in HBaseIO based on SDF it is one of the missing tests compared with the tests we had in the past for `splitAtFranction` https://github.com/apache/beam/blob/ec67a9374671ea9ae670fb0f3935ead2ebed7981/sdks/java/io/hbase/src/test/java/org/apache/beam/sdk/io/hbase/HBaseIOTest.java#L359
   
   If it is not the case, any suggestions on how to test this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org