You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/06/23 07:01:53 UTC

[GitHub] [echarts] DavidMarquezF opened a new issue, #17271: [Feature] Improve darkMode option docs

DavidMarquezF opened a new issue, #17271:
URL: https://github.com/apache/echarts/issues/17271

   ### What problem does this feature solve?
   
   Right now it is not clear how to use [darkMode from the docs](https://echarts.apache.org/en/option.html#darkMode). The values that can be assigned are explained but not how it will behave.
   
   I think it may be because it is not clear if setting darkMode to true will switch to the dark theme or it will do something else, since everywhere else in the docs it says that in order to use the dark theme you need to init the chart with that theme.
   
   Furthermore, `darkMode auto` just checks the chart's backgroundColor property, but by default it is transparent (it will always guess it is light unless the user specifies a color for background?). From the docs you might get the impression that the chart checks the background visible by the user, meaning that even though the backgroundColor  property is transparent, the chart surely has a background Color from other html elements in the web. I think it should be made more clear.
   
   ### What does the proposed API look like?
   
   Clarify the darkMode docs answering the questions stated above


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org