[GitHub] [nutch] sebastian-nagel commented on a diff in pull request #761: NUTCH-2920 -- add an OpenSearchIndexWriter

["sebastian-nagel (via GitHub)" <gi...@apache.org>]

sebastian-nagel commented on code in PR #761:
URL: https://github.com/apache/nutch/pull/761#discussion_r1124705690


##########
src/plugin/build.xml:
##########
@@ -54,6 +54,7 @@
     <ant dir="indexer-dummy" target="deploy"/>
     <ant dir="indexer-elastic" target="deploy"/>
     <ant dir="indexer-kafka" target="deploy"/>
+    <ant dir="indexer-opensearch-1x" target="deploy"/>

Review Comment:
   Should also add the new plugin to the target "clean".



##########
src/plugin/build.xml:
##########
@@ -54,6 +54,7 @@
     <ant dir="indexer-dummy" target="deploy"/>
     <ant dir="indexer-elastic" target="deploy"/>
     <ant dir="indexer-kafka" target="deploy"/>
+    <ant dir="indexer-opensearch-1x" target="deploy"/>

Review Comment:
   (if `ant clean` is called in the folder `src/plugin`)
   
   In addition, the plugin should be added to the build.xml (targets javadoc, elipse and release), same as other plugins.



##########
NOTICE-binary:
##########
@@ -1021,6 +1021,10 @@ mapdb (http://www.mapdb.org)
 webarchive-commons (https://github.com/iipc/webarchive-commons)
 - license: The Apache Software License, Version 2.0
 
+# org.opensearch.client:opensearch-rest-high-level-client

Review Comment:
   Excellent! - but we should seriously automatize keeping the licenses up-to-date, see NUTCH-2981.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@nutch.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org