You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Michael Luckey (JIRA)" <ji...@apache.org> on 2019/02/10 00:37:00 UTC

[jira] [Commented] (BEAM-4050) Move pom generation metadata logic out of build_rules.gradle

    [ https://issues.apache.org/jira/browse/BEAM-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16764270#comment-16764270 ] 

Michael Luckey commented on BEAM-4050:
--------------------------------------

Hi [~swegner]

Would you consider this as done? It seems, that after merge of [PR 5608|https://github.com/apache/beam/pull/5608] there is nothing left?

> Move pom generation metadata logic out of build_rules.gradle
> ------------------------------------------------------------
>
>                 Key: BEAM-4050
>                 URL: https://issues.apache.org/jira/browse/BEAM-4050
>             Project: Beam
>          Issue Type: Sub-task
>          Components: build-system
>            Reporter: Scott Wegner
>            Priority: Minor
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> When preparing a release, we generate pom files for each artifact to be released. Most of the pom structure is filled in automatically, but there is a good deal of metadata that needs to be manually added. The [code for manipulating the XML structure|https://github.com/apache/beam/blob/c78b96a67c0313f44d78262ee46f86aa4866a3aa/build_rules.gradle#L605] is verbose and it would make more sense to actually express it as XML rather than groovy DOM manipulations.
> It would be nice to refactor this and clean up the build_rules.gradle file a bit. Some potential ideas for refactoring:
>  # Check in a "base pom.xml" file pre-filled with metadata, and use this as the source for generated pom manipulations.
>  # Check in and release a parent pom file which contains all required metadata. Other artifacts can reference it as a parent and then drop the duplicated metadata.
>  # At the very least, refactor the pom manipulation logic out to a different method or different file.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)