[GitHub] [helix] xyuanlu commented on a diff in pull request #2381: Adding a new metric to report number of partitions with missing top state beyond threshold

["xyuanlu (via GitHub)" <gi...@apache.org>]

xyuanlu commented on code in PR #2381:
URL: https://github.com/apache/helix/pull/2381#discussion_r1116412032


##########
helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ResourceMonitor.java:
##########
@@ -78,6 +83,13 @@ public enum RebalanceStatus {
   // Histograms
   private HistogramDynamicMetric _partitionTopStateHandoffDurationGauge;
   private HistogramDynamicMetric _partitionTopStateHandoffHelixLatencyGauge;
+  // A new Gauage for reporting number of partitions with missing top state has been added. The main reason of deprecating
+  // this gauge because it's similar to other failedTopStateCounter and averaging out duration of all those handsoff
+  // won't really help in debugging the issue. Hence please use new gauage _missingTopStatePartitionsBeyondThresholdGauge
+  // to find number of partitions with missing top state beyond threshold and to find duration use
+  // _maxSinglePartitionTopStateHandoffDuration. New gauage will help with that. Please find more info at
+  // https://github.com/apache/helix/pull/2381
+  @Deprecated

Review Comment:
   No need to add duplicate comments. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org