You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by "slfan1989 (via GitHub)" <gi...@apache.org> on 2023/04/28 02:44:07 UTC

[GitHub] [hudi] slfan1989 commented on pull request #8478: [HUDI-6086] Improve HiveSchemaUtil#generateCreateDDL With StringBuilder

slfan1989 commented on PR #8478:
URL: https://github.com/apache/hudi/pull/8478#issuecomment-1526902500

   @danny0405 Thank you very much for helping to review the code and providing suggestions for improvement! I have refactored this part of the code using `StringBuilder`, as we discussed, to improve its readability. I also added some comments to provide additional context and clarification. Sorry for the delayed response.
   
   When you have time, could you please review this PR again? Thank you very much!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org