[GitHub] [pinot] klsince commented on a change in pull request #7645: to handle datetime column consistently

[GitBox <gi...@apache.org>]

klsince commented on a change in pull request #7645:
URL: https://github.com/apache/pinot/pull/7645#discussion_r738878466



##########
File path: pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/creator/SegmentGeneratorConfig.java
##########
@@ -286,18 +285,13 @@ public void setCustomProperties(Map<String, String> properties) {
     _customProperties.putAll(properties);
   }
 
-  public void setSimpleDateFormat(String simpleDateFormat) {
+  private void setSimpleDateFormat(DateTimeFormatSpec formatSpec) {

Review comment:
       I didn't see this method is used anywhere in the repo. but I can add a new method just in case.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org