[jira] [Commented] (CLOUDSTACK-4045) IP address acquired with associateIpAddress is marked as source NAT, causing disassociateIpAddress to fail later

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-4045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16749866#comment-16749866 ] 

ASF subversion and git services commented on CLOUDSTACK-4045:
-------------------------------------------------------------

Commit 323f791efca6f1d5b8bb63573d9e385c97c427e1 in cloudstack's branch refs/heads/master from Dingane Hlaluku
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=323f791 ]

IP address acquired with associate ip address is marked as source nat (#3125)

* CLOUDSTACK-4045 added a check for network state when determining whether a new IP should be source NAT. this prevents associated IP's to be marked as source NAT when the network is in allocated state, causing disassociateIpAddress to fail later

* Remove mock object that cause other tests to fail

* Remove underscores from variable types and add documentation for the created method

* Improve exception message to include network name

* Include network UUID with the Exception message and fix failing marvin test

* Rebase against latest master and format AssociateIPAddrCmd class


> IP address acquired with associateIpAddress is marked as source NAT, causing disassociateIpAddress to fail later
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-4045
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4045
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>    Affects Versions: 4.0.0, 4.0.1, 4.0.2, 4.1.0, 4.1.1, 4.2.0
>            Reporter: Murali Reddy
>            Assignee: Henko Holtzhausen
>            Priority: Major
>             Fix For: Future
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> When you can create network, network is in allocated state. when network is implemented CloudStack implicitly should acquire a public IP for source nat. But there is assumption that first IP this is associated with network is always for source NAT IP. So when you do
> 1. create network (network is in allocated state)
> 2. acquire a public IP and associate with the network
> 3. disassociate ip address
> #3 will fail because CloudStack marks the IP acquired in #1 to be source NAT. For users this is counter-intutive because when a IP is acquired, he/she should be able to release it as well.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)