You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Varun Saxena (JIRA)" <ji...@apache.org> on 2016/07/08 18:38:11 UTC

[jira] [Comment Edited] (YARN-5297) Avoid printing a stack trace when recovering an app after the RM restarts

    [ https://issues.apache.org/jira/browse/YARN-5297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15368145#comment-15368145 ] 

Varun Saxena edited comment on YARN-5297 at 7/8/16 6:37 PM:
------------------------------------------------------------

Thanks [~djp] for the replies.
bq. I think we should remove RM audit log here to be consistent with other exception handling cases nearby.
Yeah there are no audit logs in surrounding cases. I am ok with removing it but wasnt sure if it wont be used by anyone. 

bq. finishApplicationMaster is a different case and the log message level is error instead of info. 
Missed that it was an error log. We would not have a way out then. As you said, it would be printed in rare cases anyways.

Checkstyle is unrelated.
Will commit the patch.


was (Author: varun_saxena):
Thanks [~djp] for the replies.
bq. I think we should remove RM audit log here to be consistent with other exception handling cases nearby.
Yeah there are no audit logs in surrounding cases. I am ok with removing it but wasnt sure if it wont be used by anyone. 

bq. finishApplicationMaster is a different case and the log message level is error instead of info. 
Missed the error log. We would not have a way out then. As you said, it would be printed in rare cases anyways.

Checkstyle is unrelated.
Will commit the patch.

> Avoid printing a stack trace when recovering an app after the RM restarts
> -------------------------------------------------------------------------
>
>                 Key: YARN-5297
>                 URL: https://issues.apache.org/jira/browse/YARN-5297
>             Project: Hadoop YARN
>          Issue Type: Task
>            Reporter: Siddharth Seth
>            Assignee: Junping Du
>         Attachments: YARN-5297-v2.patch, YARN-5297.patch
>
>
> The exception trace is unnecessary, and can cause confusion.
> {code}
> 2016-06-16 22:02:54,262 INFO  ipc.Server (Server.java:logException(2401)) - IPC Server handler 0 on 8030, call org.apache.hadoop.yarn.api.ApplicationMasterProtocolPB.allocate from 172.22.79.149:42698 Call#2241 Retry#0
> org.apache.hadoop.yarn.exceptions.ApplicationMasterNotRegisteredException: AM is not registered for known application attempt: appattempt_1466112179488_0001_000001 or RM had restarted after AM registered . AM should re-register.
>   at org.apache.hadoop.yarn.server.resourcemanager.ApplicationMasterService.allocate(ApplicationMasterService.java:454)
>   at org.apache.hadoop.yarn.api.impl.pb.service.ApplicationMasterProtocolPBServiceImpl.allocate(ApplicationMasterProtocolPBServiceImpl.java:60)
>   at org.apache.hadoop.yarn.proto.ApplicationMasterProtocol$ApplicationMasterProtocolService$2.callBlockingMethod(ApplicationMasterProtocol.java:99)
>   at org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:640)
>   at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:969)
>   at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2313)
>   at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2309)
>   at java.security.AccessController.doPrivileged(Native Method)
>   at javax.security.auth.Subject.doAs(Subject.java:422)
>   at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1724)
>   at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2307)
> {code}
> cc [~djp]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org