You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by xujk2008 <gi...@git.apache.org> on 2017/07/27 03:52:35 UTC
[GitHub] incubator-weex pull request #546: +[ios] 0.16-dev update code for component/...
GitHub user xujk2008 opened a pull request:
https://github.com/apache/incubator-weex/pull/546
+[ios] 0.16-dev update code for component/module validation
Add `options` for module validation to get `isvAppKey`. For component validation, `isvAppKey` would be fetched from `superComponent`.
Demo is here: http://www.google.com/)https://www.taobao.com/?_wx_tpl=http://gitlab.alibaba-inc.com/rax/wangpu-pageinit/raw/isv_check/demo/native.bundle.js
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xujk2008/incubator-weex 0.16-dev
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/546.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #546
----
commit b563c6db27342f92e8e0ce3ab06b9520071d0eeb
Author: xujk2008 <xu...@gmail.com>
Date: 2017-07-26T02:50:01Z
+[ios] update code for component/module validation
commit a54bcb91d4776bb76aba277f209d57aa79a1396b
Author: xujk2008 <xu...@gmail.com>
Date: 2017-07-26T03:48:10Z
delete useless 'define' in WXComponentManager
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #546: +[ios] 0.16-dev update code for component/...
Posted by xujk2008 <gi...@git.apache.org>.
GitHub user xujk2008 reopened a pull request:
https://github.com/apache/incubator-weex/pull/546
+[ios] 0.16-dev update code for component/module validation
Add `options` for module validation to get `isvAppKey`. For component validation, `isvAppKey` would be fetched from `superComponent`.
Demo is here: http://www.google.com/)https://www.taobao.com/?_wx_tpl=http://gitlab.alibaba-inc.com/rax/wangpu-pageinit/raw/isv_check/demo/native.bundle.js
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xujk2008/incubator-weex 0.16-dev
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/546.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #546
----
commit b563c6db27342f92e8e0ce3ab06b9520071d0eeb
Author: xujk2008 <xu...@gmail.com>
Date: 2017-07-26T02:50:01Z
+[ios] update code for component/module validation
commit a54bcb91d4776bb76aba277f209d57aa79a1396b
Author: xujk2008 <xu...@gmail.com>
Date: 2017-07-26T03:48:10Z
delete useless 'define' in WXComponentManager
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #546: +[ios] 0.16-dev update code for component/...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/546
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #546: +[ios] 0.16-dev update code for component/...
Posted by xujk2008 <gi...@git.apache.org>.
Github user xujk2008 closed the pull request at:
https://github.com/apache/incubator-weex/pull/546
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #546: +[ios] 0.16-dev update code for component/module ...
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/546
<!--
1 failure: This PR modify SD...
2 warning: No Changelog chan..., This PR should up...
1 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Fails</th>
</tr>
</thead>
<tbody><tr>
<td>:no_entry_sign:</td>
<td>This PR modify SDK code. Please add/modify corresponding testcases. If it is ok, please comment about it. Or put '@notdanger' in you commit message.</td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Warnings</th>
</tr>
</thead>
<tbody><tr>
<td>:warning:</td>
<td>No Changelog changes!</td>
</tr>
<tr>
<td>:warning:</td>
<td>This PR should update related documents as well. </td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>According to the blame info, we recommended @cxfeng1 , @acton393 to be the reviewers.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---