[GitHub] [doris] morningman commented on a diff in pull request #18609: [Fix](variables) fix session variable does not take effect immediately when set global variable in follower FE

["morningman (via GitHub)" <gi...@apache.org>]

morningman commented on code in PR #18609:
URL: https://github.com/apache/doris/pull/18609#discussion_r1164976134


##########
fe/fe-core/src/main/java/org/apache/doris/qe/MasterOpExecutor.java:
##########
@@ -163,6 +179,24 @@ private void forward() throws Exception {
         }
     }
 
+    // The SetStmt needs to be executed in follower again
+    // for the current session after master success
+    private void afterForwardExecute() throws DdlException {
+        if (parsedStmt != null) {
+            if (parsedStmt instanceof SetStmt) {
+                SetExecutor executor = new SetExecutor(ctx, (SetStmt) parsedStmt);
+                try {
+                    executor.setSessionVars();

Review Comment:
   I think we can set remove the `global` property in `SetStmt` and than call `executor.execute()` method. No need to create a new method `setSessionVars()`.



##########
fe/fe-core/src/main/java/org/apache/doris/qe/SetExecutor.java:
##########
@@ -59,9 +59,24 @@ private void setVariable(SetVar var) throws DdlException {
         }
     }
 
+    private boolean isSessionVar(SetVar var) {
+        return !(var instanceof SetPassVar

Review Comment:
   This is error-prone, if other people at a new subclass of `SetVar`, this method may be missed.
   How about add a `SetVarType` or something to specify the stmt's type directly?
   And write like `return var.setType() == Type.SET_SESSION_VAR`;



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org