You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/09/21 20:00:09 UTC
[kudu-CR](branch-1.13.x) [thirdparty] fix LLVM compilation on Ubuntu 20.04
Hello Kudu Jenkins, Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/16487
to review the following change.
Change subject: [thirdparty] fix LLVM compilation on Ubuntu 20.04
......................................................................
[thirdparty] fix LLVM compilation on Ubuntu 20.04
This changelist adds a patch from the llvm-toolchain-9-9.0.1 Debian
source package to fix compilation of LLVM 9.0 in Kudu thirdparty
on Ubuntu 20.04 LTS. See [1], [2] for the original source of the patch.
The patch is already included in the upstream LLVM repo and included
into 10.0.0 and later releases.
[1] https://reviews.llvm.org/rG947f9692440
[2] https://github.com/llvm/llvm-project/commit/947f9692440836dcb8d88b74b69dd379d85974ce
Change-Id: Ifba0bf6ba660a536ed54ddce228a38470dd1c650
Reviewed-on: http://gerrit.cloudera.org:8080/16477
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
(cherry picked from commit 2bed4068c53fcc6084e8e8742437846cf417a746)
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/llvm-947f9692440836dcb8d88b74b69dd379d85974ce.patch
2 files changed, 84 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/87/16487/1
--
To view, visit http://gerrit.cloudera.org:8080/16487
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.13.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifba0bf6ba660a536ed54ddce228a38470dd1c650
Gerrit-Change-Number: 16487
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.13.x) [thirdparty] fix LLVM compilation on Ubuntu 20.04
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16487 )
Change subject: [thirdparty] fix LLVM compilation on Ubuntu 20.04
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16487
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.13.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifba0bf6ba660a536ed54ddce228a38470dd1c650
Gerrit-Change-Number: 16487
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 22 Sep 2020 16:07:24 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.13.x) [thirdparty] fix LLVM compilation on Ubuntu 20.04
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16487 )
Change subject: [thirdparty] fix LLVM compilation on Ubuntu 20.04
......................................................................
Patch Set 1:
> Patch Set 1: Code-Review+2
Do we want to backport these to branch-1.13.x just in case we release a 1.13.1? If that's the case, maybe it's worth backporting to branch-1.12.x and branch-1.11.x as well.
--
To view, visit http://gerrit.cloudera.org:8080/16487
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.13.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifba0bf6ba660a536ed54ddce228a38470dd1c650
Gerrit-Change-Number: 16487
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 22 Sep 2020 16:18:06 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.13.x) [thirdparty] fix LLVM compilation on Ubuntu 20.04
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16487 )
Change subject: [thirdparty] fix LLVM compilation on Ubuntu 20.04
......................................................................
[thirdparty] fix LLVM compilation on Ubuntu 20.04
This changelist adds a patch from the llvm-toolchain-9-9.0.1 Debian
source package to fix compilation of LLVM 9.0 in Kudu thirdparty
on Ubuntu 20.04 LTS. See [1], [2] for the original source of the patch.
The patch is already included in the upstream LLVM repo and included
into 10.0.0 and later releases.
[1] https://reviews.llvm.org/rG947f9692440
[2] https://github.com/llvm/llvm-project/commit/947f9692440836dcb8d88b74b69dd379d85974ce
Change-Id: Ifba0bf6ba660a536ed54ddce228a38470dd1c650
Reviewed-on: http://gerrit.cloudera.org:8080/16477
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
(cherry picked from commit 2bed4068c53fcc6084e8e8742437846cf417a746)
Reviewed-on: http://gerrit.cloudera.org:8080/16487
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/llvm-947f9692440836dcb8d88b74b69dd379d85974ce.patch
2 files changed, 84 insertions(+), 2 deletions(-)
Approvals:
Kudu Jenkins: Verified
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/16487
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.13.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifba0bf6ba660a536ed54ddce228a38470dd1c650
Gerrit-Change-Number: 16487
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.13.x) [thirdparty] fix LLVM compilation on Ubuntu 20.04
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16487 )
Change subject: [thirdparty] fix LLVM compilation on Ubuntu 20.04
......................................................................
Patch Set 1:
> > Patch Set 1: Code-Review+2
>
> Do we want to backport these to branch-1.13.x just in case we
> release a 1.13.1? If that's the case, maybe it's worth backporting
> to branch-1.12.x and branch-1.11.x as well.
Yup, I guess we want since that's exactly the patch for the branch-1.3.x :)
I've just posted back-ports for 1.12.x branch for review as well. As for 1.11.x, I think 1.11.x branch is supposed to be archived at point, no? Also, Ubuntu 20.04 LTS was released 6 month later than 1.11.1, so I'm not sure we want to stretch too far back there.
--
To view, visit http://gerrit.cloudera.org:8080/16487
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.13.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifba0bf6ba660a536ed54ddce228a38470dd1c650
Gerrit-Change-Number: 16487
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 22 Sep 2020 17:28:24 +0000
Gerrit-HasComments: No