You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@zookeeper.apache.org by "Kezhu Wang (Jira)" <ji...@apache.org> on 2022/07/26 14:04:00 UTC
[jira] [Commented] (ZOOKEEPER-4601) Define getConfig Watcher behavior in chroot ZooKeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-4601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571448#comment-17571448 ]
Kezhu Wang commented on ZOOKEEPER-4601:
---------------------------------------
Personally, I prefer {{getConfig}} watcher to always receive "/zookeeper/config". But I am afraid this might be a breaking change.
After time travel in source codes, I found:
* {{getConfig}} was introduced in ZOOKEEPER-107 which is landed in 3.5.
* Strip code before ZOOKEEPER-4565 was introduced in ZOOKEEPER-237, ZOOKEEPER-682 and ZOOKEEPER-961 which are all landed before 3.5.
This means that {{getConfig}} never receive legal path before ZOOKEEPER-4565. So, I think this means we can do whatever that make sense as long as it is landed along with ZOOKEEPER-4565.
Any thoughts [~eolivelli] [~symat] [~maoling] [~Tison]
> Define getConfig Watcher behavior in chroot ZooKeeper
> -----------------------------------------------------
>
> Key: ZOOKEEPER-4601
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4601
> Project: ZooKeeper
> Issue Type: Improvement
> Components: java client
> Reporter: Kezhu Wang
> Priority: Critical
>
> After ZOOKEEPER-4565, {{getConfig}} watcher will receive path for zookeeper config node "/zookeeper/config". But if the path {{getConfig}} watcher received is somewhat sensitive to chroot path.
> * With chroot path "/zookeeper", {{getConfig}} will receive path "/config".
> * With other chroot paths, {{getConfig}} will receive path "/zookeeper/config".
> I think we should define what path {{getConfig}} will get formally to avoid unnoticed behavior.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)