You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/12 04:56:45 UTC
[GitHub] [arrow] thisisnic commented on pull request #12125: ARROW-15303: [R] linting errors
thisisnic commented on pull request #12125:
URL: https://github.com/apache/arrow/pull/12125#issuecomment-1010635162
> What is present here looks good, but locally I get additional linting errors:
>
> ```
> > lintr::lint_package()
> ...........................................................................................................................................
> tests/testthat/test-Array.R:357:22: style: Place a space before left parenthesis, except in a function call.
> a <- Array$create(-(1:10))
> ^
> tests/testthat/test-compute-arith.R:110:18: style: Place a space before left parenthesis, except in a function call.
> expect_equal(a^(-1), Array$create(c(1, 1 / 2, 1 / 3, 1 / 4, NA_real_)))
> ^
> tests/testthat/test-compute-arith.R:111:18: style: Place a space before left parenthesis, except in a function call.
> expect_equal(a^(.5), Array$create(c(1, sqrt(2), sqrt(3), sqrt(4), NA_real_)))
> ^
> tests/testthat/test-compute-arith.R:115:18: style: Place a space before left parenthesis, except in a function call.
> expect_equal(b^(-1), Array$create(c(1, 1 / 2, 1 / 3, 1 / 4, NA_real_)))
> ^
> tests/testthat/test-compute-arith.R:116:18: style: Place a space before left parenthesis, except in a function call.
> expect_equal(b^(.5), Array$create(c(1, sqrt(2), sqrt(3), sqrt(4), NA_real_)))
> ^
> tests/testthat/test-compute-arith.R:120:18: style: Place a space before left parenthesis, except in a function call.
> expect_equal(c^(-1), Array$create(c(1, 1 / 2, 1 / 3, 1 / 4, NA_real_)))
> ^
> tests/testthat/test-compute-arith.R:121:18: style: Place a space before left parenthesis, except in a function call.
> expect_equal(c^(.5), Array$create(c(1, sqrt(2), sqrt(3), sqrt(4), NA_real_)))
> ^
> tests/testthat/test-compute-arith.R:125:18: style: Place a space before left parenthesis, except in a function call.
> expect_equal(d^(-1), Array$create(c(1, 1 / 2, 1 / 3, 1 / 4, NA_real_)))
> ^
> tests/testthat/test-compute-arith.R:126:18: style: Place a space before left parenthesis, except in a function call.
> expect_equal(d^(.5), Array$create(c(1, sqrt(2), sqrt(3), sqrt(4), NA_real_)))
> ```
>
> Do you see those too? Or is there something wrong with my linting settings?
That's strange; I don't get those locally, but unsure why we have different results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org