You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by spmallette <gi...@git.apache.org> on 2015/12/09 11:50:04 UTC
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1035 Improved consiste...
GitHub user spmallette opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/174
TINKERPOP-1035 Improved consistency of transaction management in gremlin server.
https://issues.apache.org/jira/browse/TINKERPOP-1035
Sessionless requests now have special handling for `GraphTraversal` return results. Gremlin Server now force iterates those results (when they include `Mutating` steps) to a `List`. It then commits and then iterates that `List`. For all other results the commit occurs in the same spot, but doesn't force iterate which allows results to stream as they always have.
Tested manually and with:
```text
mvn clean install
mvn verify -DskipIntegrationTests=false -pl gremlin-server
```
VOTE: +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-1035
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/174.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #174
----
commit dbc7f94c343f5ca8d4e51c0354280b552c231967
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2015-12-09T00:50:18Z
Improved consistency of transaction management in gremlin server.
Sessionless requests now have special handling for GraphTraversal return results. Gremlin Server now force iterates those results (when they include Mutating steps) to a List. It then commits and then iterates that List. For all other results the commit occurs in the same spot, but doesn't force iterate which allows results to stream as they always have.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1035 Improved consiste...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-tinkerpop/pull/174
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1035 Improved consiste...
Posted by twilmes <gi...@git.apache.org>.
Github user twilmes commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/174#issuecomment-163292556
Tests pass and the doc updates were good. I think this will help clarify things for folks.
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1035 Improved consiste...
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/174#issuecomment-163296472
VOTE +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---