[GitHub] [spark] xuanyuanking commented on a change in pull request #25327: [SPARK-28593][CORE] Rename ShuffleClient to BlockStoreClient which more close to its usage

[GitBox <gi...@apache.org>]

xuanyuanking commented on a change in pull request #25327: [SPARK-28593][CORE] Rename ShuffleClient to BlockStoreClient which more close to its usage
URL: https://github.com/apache/spark/pull/25327#discussion_r309994236
 
 

 ##########
 File path: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalBlockStoreClient.java
 ##########
 @@ -46,8 +46,8 @@
  * BlockTransferService), which has the downside of losing the shuffle data if we lose the
  * executors.
  */
-public class ExternalShuffleClient extends ShuffleClient {
-  private static final Logger logger = LoggerFactory.getLogger(ExternalShuffleClient.class);
+public class ExternalBlockStoreClient extends BlockStoreClient {
 
 Review comment:
   Ah, yep, done in ae64538.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org