You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/07/01 14:44:28 UTC

[GitHub] [incubator-apisix-dashboard] imjoey opened a new pull request #293: Fix incorrect format of some go source files

imjoey opened a new pull request #293:
URL: https://github.com/apache/incubator-apisix-dashboard/pull/293


   Use `gofmt` command to format codes, as well as re-organize the imports in a conventional way via `goimports` command. 
   
   > BTW: I guess that would be great if we add these two command to make static check for go codes. Maybe that could be done in another PR.
   
   Signed-off-by: imjoey <ma...@gmail.com>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-apisix-dashboard] imjoey commented on pull request #293: Fix incorrect format of some go source files

Posted by GitBox <gi...@apache.org>.
imjoey commented on pull request #293:
URL: https://github.com/apache/incubator-apisix-dashboard/pull/293#issuecomment-655319035


   @juzhiyuan @gxthrj  Thank you very much.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-apisix-dashboard] juzhiyuan merged pull request #293: Fix incorrect format of some go source files

Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #293:
URL: https://github.com/apache/incubator-apisix-dashboard/pull/293


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on pull request #293: Fix incorrect format of some go source files

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #293:
URL: https://github.com/apache/incubator-apisix-dashboard/pull/293#issuecomment-652899425


   @gxthrj 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-apisix-dashboard] imjoey commented on pull request #293: Fix incorrect format of some go source files

Posted by GitBox <gi...@apache.org>.
imjoey commented on pull request #293:
URL: https://github.com/apache/incubator-apisix-dashboard/pull/293#issuecomment-654015567


   Hi @gxthrj , PTAL. Many thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org