You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2015/05/21 23:05:09 UTC
svn commit: r1680953 - in /tomcat/trunk/java/org/apache:
coyote/http2/Http2UpgradeHandler.java
tomcat/util/http/LegacyCookieProcessor.java
tomcat/util/http/Rfc6265CookieProcessor.java
Author: markt
Date: Thu May 21 21:05:09 2015
New Revision: 1680953
URL: http://svn.apache.org/r1680953
Log:
Remove some warning stack traces from the logs and add some TODOs to review the relevant code.
Modified:
tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java
tomcat/trunk/java/org/apache/tomcat/util/http/LegacyCookieProcessor.java
tomcat/trunk/java/org/apache/tomcat/util/http/Rfc6265CookieProcessor.java
Modified: tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java?rev=1680953&r1=1680952&r2=1680953&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java Thu May 21 21:05:09 2015
@@ -56,6 +56,8 @@ import org.apache.tomcat.util.res.String
* (tested with v37.0.2) needs to be configured with
* network.http.spdy.enforce-tls-profile=false in order for FireFox to be able
* to connect.
+ *
+ * TODO: Review cookie parsing
*/
public class Http2UpgradeHandler extends AbstractStream implements InternalHttpUpgradeHandler {
Modified: tomcat/trunk/java/org/apache/tomcat/util/http/LegacyCookieProcessor.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/http/LegacyCookieProcessor.java?rev=1680953&r1=1680952&r2=1680953&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/tomcat/util/http/LegacyCookieProcessor.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/http/LegacyCookieProcessor.java Thu May 21 21:05:09 2015
@@ -255,7 +255,8 @@ public final class LegacyCookieProcessor
if (cookieValue != null && !cookieValue.isNull() ) {
if (cookieValue.getType() != MessageBytes.T_BYTES ) {
Exception e = new Exception();
- log.warn("Cookies: Parsing cookie as String. Expected bytes.", e);
+ // TODO: Review this in light of HTTP/2
+ log.debug("Cookies: Parsing cookie as String. Expected bytes.", e);
cookieValue.toBytes();
}
if (log.isDebugEnabled()) {
Modified: tomcat/trunk/java/org/apache/tomcat/util/http/Rfc6265CookieProcessor.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/http/Rfc6265CookieProcessor.java?rev=1680953&r1=1680952&r2=1680953&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/tomcat/util/http/Rfc6265CookieProcessor.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/http/Rfc6265CookieProcessor.java Thu May 21 21:05:09 2015
@@ -74,7 +74,8 @@ public class Rfc6265CookieProcessor impl
if (cookieValue != null && !cookieValue.isNull() ) {
if (cookieValue.getType() != MessageBytes.T_BYTES ) {
Exception e = new Exception();
- log.warn("Cookies: Parsing cookie as String. Expected bytes.", e);
+ // TODO: Review this in light of HTTP/2
+ log.debug("Cookies: Parsing cookie as String. Expected bytes.", e);
cookieValue.toBytes();
}
if (log.isDebugEnabled()) {
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org