You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2017/02/01 01:44:12 UTC

[kudu-CR] [security] Add negotiation test with TLS + GSSAPI

Hello Todd Lipcon,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/5849

to review the following change.

Change subject: [security] Add negotiation test with TLS + GSSAPI
......................................................................

[security] Add negotiation test with TLS + GSSAPI

This is a WIP since the test is not yet passing, due to the client
failing verification of the server's self-signed cert.

Change-Id: I37a3010c7b13e9cb64f1f9397b39efcc4bf3ab41
---
M src/kudu/rpc/negotiation-test.cc
1 file changed, 71 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/5849/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5849
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I37a3010c7b13e9cb64f1f9397b39efcc4bf3ab41
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] [security] Add negotiation test with TLS + GSSAPI

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: [security] Add negotiation test with TLS + GSSAPI
......................................................................


Patch Set 1:

Just in case you missed it on slack, here's what I said:

> @dan my patch as it is doesn't fix your verification problem -- haven't hooked together the bit that says "if I"m using GSSAPI I don't need to verify the server cert"
> although my tip patch (the WIP integration one) does set VERIFY_NONE for both client and server negotiation
> so in that sense it "fixes" it, but it also just disables security

-- 
To view, visit http://gerrit.cloudera.org:8080/5849
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I37a3010c7b13e9cb64f1f9397b39efcc4bf3ab41
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] [security] Add negotiation test with TLS + GSSAPI

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has abandoned this change.

Change subject: [security] Add negotiation test with TLS + GSSAPI
......................................................................


Abandoned

Rolled into https://gerrit.cloudera.org/#/c/5865/

-- 
To view, visit http://gerrit.cloudera.org:8080/5849
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I37a3010c7b13e9cb64f1f9397b39efcc4bf3ab41
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>