You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by Ryan Rawson <ry...@gmail.com> on 2010/10/18 22:42:36 UTC
Review Request: HBASE-2985 multi() no longer calls HRegion.put(list) when
possible
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1038/
-----------------------------------------------------------
Review request for hbase.
Summary
-------
This fixes multi() to call the batch-versions of Put in HRegion to reclaim performance.
This addresses bug HBASE-2985.
http://issues.apache.org/jira/browse/HBASE-2985
Diffs
-----
trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 1023115
trunk/src/main/java/org/apache/hadoop/hbase/client/MultiResponse.java 1023115
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 1023115
Diff: http://review.cloudera.org/r/1038/diff
Testing
-------
Thanks,
Ryan
Re: Review Request: HBASE-2985 multi() no longer calls HRegion.put(list)
when possible
Posted by Ryan Rawson <ry...@gmail.com>.
> On 2010-10-18 16:15:13, stack wrote:
> > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java, line 2357
> > <http://review.cloudera.org/r/1038/diff/1/?file=14871#file14871line2357>
> >
> > Remove this message on commit
> >
i think it's a legit comment, people might need that printf debugging in prod :-)
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1038/#review1566
-----------------------------------------------------------
On 2010-10-18 13:42:36, Ryan Rawson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/1038/
> -----------------------------------------------------------
>
> (Updated 2010-10-18 13:42:36)
>
>
> Review request for hbase.
>
>
> Summary
> -------
>
> This fixes multi() to call the batch-versions of Put in HRegion to reclaim performance.
>
>
> This addresses bug HBASE-2985.
> http://issues.apache.org/jira/browse/HBASE-2985
>
>
> Diffs
> -----
>
> trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 1023115
> trunk/src/main/java/org/apache/hadoop/hbase/client/MultiResponse.java 1023115
> trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 1023115
>
> Diff: http://review.cloudera.org/r/1038/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ryan
>
>
Re: Review Request: HBASE-2985 multi() no longer calls HRegion.put(list)
when possible
Posted by st...@duboce.net.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1038/#review1566
-----------------------------------------------------------
Ship it!
+1 except for all the crud that you left in the patch... please clean before commit (Do tests pass)?
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
<http://review.cloudera.org/r/1038/#comment5273>
Remove this message on commit
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
<http://review.cloudera.org/r/1038/#comment5274>
Ugh. Remove this too.
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
<http://review.cloudera.org/r/1038/#comment5275>
This too.
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
<http://review.cloudera.org/r/1038/#comment5276>
This!
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
<http://review.cloudera.org/r/1038/#comment5277>
This.
- stack
On 2010-10-18 13:42:36, Ryan Rawson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/1038/
> -----------------------------------------------------------
>
> (Updated 2010-10-18 13:42:36)
>
>
> Review request for hbase.
>
>
> Summary
> -------
>
> This fixes multi() to call the batch-versions of Put in HRegion to reclaim performance.
>
>
> This addresses bug HBASE-2985.
> http://issues.apache.org/jira/browse/HBASE-2985
>
>
> Diffs
> -----
>
> trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 1023115
> trunk/src/main/java/org/apache/hadoop/hbase/client/MultiResponse.java 1023115
> trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 1023115
>
> Diff: http://review.cloudera.org/r/1038/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ryan
>
>
Re: Review Request: HBASE-2985 multi() no longer calls HRegion.put(list)
when possible
Posted by Ryan Rawson <ry...@gmail.com>.
> On 2010-10-18 14:16:08, Ted Yu wrote:
> > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java, line 2388
> > <http://review.cloudera.org/r/1038/diff/1/?file=14871#file14871line2388>
> >
> > Please translate error status code to result
Result objects are always 'successful', because normally in a Get or Scan/next call you get the Result or an exception via a throw. So it is impossible to translate an error code into a Result object, which is what is needed here.
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1038/#review1557
-----------------------------------------------------------
On 2010-10-18 13:42:36, Ryan Rawson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/1038/
> -----------------------------------------------------------
>
> (Updated 2010-10-18 13:42:36)
>
>
> Review request for hbase.
>
>
> Summary
> -------
>
> This fixes multi() to call the batch-versions of Put in HRegion to reclaim performance.
>
>
> This addresses bug HBASE-2985.
> http://issues.apache.org/jira/browse/HBASE-2985
>
>
> Diffs
> -----
>
> trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 1023115
> trunk/src/main/java/org/apache/hadoop/hbase/client/MultiResponse.java 1023115
> trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 1023115
>
> Diff: http://review.cloudera.org/r/1038/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ryan
>
>
Re: Review Request: HBASE-2985 multi() no longer calls HRegion.put(list)
when possible
Posted by Ted Yu <te...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1038/#review1557
-----------------------------------------------------------
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
<http://review.cloudera.org/r/1038/#comment5256>
Please translate error status code to result
- Ted
On 2010-10-18 13:42:36, Ryan Rawson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/1038/
> -----------------------------------------------------------
>
> (Updated 2010-10-18 13:42:36)
>
>
> Review request for hbase.
>
>
> Summary
> -------
>
> This fixes multi() to call the batch-versions of Put in HRegion to reclaim performance.
>
>
> This addresses bug HBASE-2985.
> http://issues.apache.org/jira/browse/HBASE-2985
>
>
> Diffs
> -----
>
> trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 1023115
> trunk/src/main/java/org/apache/hadoop/hbase/client/MultiResponse.java 1023115
> trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 1023115
>
> Diff: http://review.cloudera.org/r/1038/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ryan
>
>