You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by HeartSaVioR <gi...@git.apache.org> on 2016/07/18 04:45:47 UTC
[GitHub] storm pull request #1573: STORM-1977 Restore logic: give up leadership when ...
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/1573
STORM-1977 Restore logic: give up leadership when elected as leader but doesn't have any of topology codes on local
* Nimbus H/A introduced condition for becoming a leader
* It got removed when BlobStore was introduced
* This patch is restoring previous logic with making logic compatible to BlobStore
Please refer [STORM-1977](issues.apache.org/jira/browse/STORM-1977) for more details.
Tested with the scenario I've described from STORM-1977
1. comment cleanup-corrupt-topologies! from nimbus.clj (It's a quick workaround for resolving STORM-1976), and patch Storm cluster
2. Launch Nimbus 1 (leader)
3. Run topology1
4. Kill Nimbus 1
5. Launch Nimbus 2 from different node
6. Nimbus 2 gains leadership but since it doesn't have topology1 it gives up leadership
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-1977
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1573.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1573
----
commit 8ce4811ba00f3853ad4a4d8a37af7ecb4742e9f5
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2016-07-18T04:38:36Z
STORM-1977 Restore logic: give up leadership when elected as leader but doesn't have any of topology codes on local
* Nimbus H/A introduced condition for becoming a leader
* It got removed when BlobStore was introduced
* This patch is restoring previous logic with making logic compatible to BlobStore
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1573: STORM-1977 Restore logic: give up leadership when ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1573
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---