You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/12/05 05:38:28 UTC

[GitHub] [pulsar] ericsyh commented on pull request #18691: [fix][doc] remove irrelevant components metrics links under broker section

ericsyh commented on PR #18691:
URL: https://github.com/apache/pulsar/pull/18691#issuecomment-1336777277

   > Thanks for your contribution! May I ask why the contents in the green boxes are not exactly the same (while they should be)? <img alt="image" width="947" src="https://user-images.githubusercontent.com/50226895/205551860-c16e44fd-5cf6-4724-923d-190c7a469032.png">
   
   I think they should keep same, and I guess I find some issues here
   
   1. Duplicate for `Replication metrics`
   
   <img width="443" alt="截屏2022-12-05 下午1 33 30" src="https://user-images.githubusercontent.com/10498732/205557169-1787d7b8-e542-4c73-91fa-61e72a1f6e8a.png">
   
   2. The markdown title level should be 3 not 4 on `Replication metrics` which make the right side ToC miss to scrape it. 
   
   <img width="1095" alt="截屏2022-12-05 下午1 36 59" src="https://user-images.githubusercontent.com/10498732/205557574-e9f5c729-a25d-4e31-93f5-3b127db8cf3a.png">
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org