[GitHub] mistercrunch commented on a change in pull request #5584: [fix] Enforcing main dttm column

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #5584: [fix] Enforcing main dttm column
URL: https://github.com/apache/incubator-superset/pull/5584#discussion_r209486803
 
 

 ##########
 File path: superset/assets/src/explore/controls.jsx
 ##########
 @@ -846,6 +841,12 @@ export const controls = {
       const newState = {};
       if (state.datasource) {
         newState.options = state.datasource.columns.filter(c => c.is_dttm);
+        newState.default = null;
 
 Review comment:
   Not related to your PR: `props` would be a better variable name than `newState` in this method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org