You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "atu-sharm (via GitHub)" <gi...@apache.org> on 2023/05/23 12:27:09 UTC

[GitHub] [kafka] atu-sharm opened a new pull request, #13745: KAFKA-15015: Explicit on reload4j version

atu-sharm opened a new pull request, #13745:
URL: https://github.com/apache/kafka/pull/13745

   Defining a specific version for reload4j
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] showuon commented on pull request #13745: KAFKA-15015: Explicit on reload4j version

Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon commented on PR #13745:
URL: https://github.com/apache/kafka/pull/13745#issuecomment-1560336419

   Failed tests also failed in trunk build
   ```
       Build / JDK 17 and Scala 2.13 / kafka.server.ListOffsetsRequestTest.testResponseIncludesLeaderEpoch()
       Build / JDK 17 and Scala 2.13 / kafka.server.ListOffsetsRequestTest.testResponseIncludesLeaderEpoch()
       Build / JDK 17 and Scala 2.13 / kafka.server.ListOffsetsRequestWithRemoteStoreTest.testResponseIncludesLeaderEpoch()
       Build / JDK 17 and Scala 2.13 / kafka.server.ListOffsetsRequestWithRemoteStoreTest.testResponseIncludesLeaderEpoch()
       Build / JDK 17 and Scala 2.13 / org.apache.kafka.trogdor.coordinator.CoordinatorTest.testTaskRequestWithOldStartMsGetsUpdated()
       Build / JDK 11 and Scala 2.13 / integration.kafka.server.FetchFromFollowerIntegrationTest.testRackAwareRangeAssignor()
       Build / JDK 11 and Scala 2.13 / integration.kafka.server.FetchFromFollowerIntegrationTest.testRackAwareRangeAssignor()
       Build / JDK 11 and Scala 2.13 / kafka.api.ConsumerBounceTest.testSubscribeWhenTopicUnavailable()
       Build / JDK 11 and Scala 2.13 / kafka.server.ListOffsetsRequestTest.testResponseIncludesLeaderEpoch()
       Build / JDK 11 and Scala 2.13 / kafka.server.ListOffsetsRequestTest.testResponseIncludesLeaderEpoch()
       Build / JDK 11 and Scala 2.13 / kafka.server.ListOffsetsRequestWithRemoteStoreTest.testResponseIncludesLeaderEpoch()
       Build / JDK 11 and Scala 2.13 / kafka.server.ListOffsetsRequestWithRemoteStoreTest.testResponseIncludesLeaderEpoch()
       Build / JDK 11 and Scala 2.13 / org.apache.kafka.streams.integration.StoreQueryIntegrationTest.shouldQueryStoresAfterAddingAndRemovingStreamThread()
       Build / JDK 11 and Scala 2.13 / org.apache.kafka.trogdor.coordinator.CoordinatorTest.testTaskRequestWithOldStartMsGetsUpdated()
       Build / JDK 8 and Scala 2.12 / kafka.server.ListOffsetsRequestTest.testResponseIncludesLeaderEpoch()
       Build / JDK 8 and Scala 2.12 / kafka.server.ListOffsetsRequestTest.testResponseIncludesLeaderEpoch()
       Build / JDK 8 and Scala 2.12 / kafka.server.ListOffsetsRequestWithRemoteStoreTest.testResponseIncludesLeaderEpoch()
       Build / JDK 8 and Scala 2.12 / kafka.server.ListOffsetsRequestWithRemoteStoreTest.testResponseIncludesLeaderEpoch()
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] showuon merged pull request #13745: KAFKA-15015: Explicit on reload4j version

Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon merged PR #13745:
URL: https://github.com/apache/kafka/pull/13745


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] atu-sharm commented on pull request #13745: KAFKA-15015: Explicit on reload4j version

Posted by "atu-sharm (via GitHub)" <gi...@apache.org>.
atu-sharm commented on PR #13745:
URL: https://github.com/apache/kafka/pull/13745#issuecomment-1559239546

   Output:
   ```
   reload4j-1.2.25.jar
   slf4j-reload4j-1.7.36.jar
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] showuon commented on pull request #13745: KAFKA-15015: Explicit on reload4j version

Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon commented on PR #13745:
URL: https://github.com/apache/kafka/pull/13745#issuecomment-1560339089

   Backported to 3.4 and 3.5 branch. @mimaison , if you have another RC build, this duplicated reload4j binary issue will be fixed. FYI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] atu-sharm commented on pull request #13745: KAFKA-15015: Explicit on reload4j version

Posted by "atu-sharm (via GitHub)" <gi...@apache.org>.
atu-sharm commented on PR #13745:
URL: https://github.com/apache/kafka/pull/13745#issuecomment-1559203084

   @showuon @mimaison can you review?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] showuon commented on pull request #13745: KAFKA-15015: Explicit on reload4j version

Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon commented on PR #13745:
URL: https://github.com/apache/kafka/pull/13745#issuecomment-1559220469

   @atu-sharm , could you run these commands to show what's the output of the lib folder for reload library?
   ```
   // build the binary artifacts
   $ ./gradlewAll releaseTarGz
   
   // unpack the binary artifact 
   $ tar xf core/build/distributions/kafka_2.13-X.Y.Z.tgz
   $ cd xf kafka_2.13-X.Y.Z
   
   // list the packaged jars 
   // (you can ignore the jars for our own modules, like kafka, kafka-clients, etc.)
   $ ls libs | grep reload
   ```
   
   Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org