You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by GitBox <gi...@apache.org> on 2020/05/08 23:05:27 UTC
[GitHub] [myfaces] pnicolucci opened a new pull request #104: Animal snipper plugin updates and ignores
pnicolucci opened a new pull request #104:
URL: https://github.com/apache/myfaces/pull/104
1) Update the Animal Sniffer Plugin to the latest version as the old version was not working correctly with the `@IgnoreJRERequirement` annotation.
2) Add the `animal-sniffer-annotations` as a dependency so we can compile with `@IgnoreJRERequirment`
3) Add `@IgnoreJRERequirement` to the methods that use `isSurrogate`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] tandraschko commented on pull request #104: Animal sniffer plugin updates and ignores
Posted by GitBox <gi...@apache.org>.
tandraschko commented on pull request #104:
URL: https://github.com/apache/myfaces/pull/104#issuecomment-626125849
Is optional preffered over scope provided?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] pnicolucci commented on pull request #104: Animal sniffer plugin updates and ignores
Posted by GitBox <gi...@apache.org>.
pnicolucci commented on pull request #104:
URL: https://github.com/apache/myfaces/pull/104#issuecomment-626655465
@tandraschko @wtlucy yes I just kept consistent with what was already in the pom as well as following the instructions for the plugin: https://www.mojohaus.org/animal-sniffer/animal-sniffer-annotations/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] wtlucy commented on pull request #104: Animal sniffer plugin updates and ignores
Posted by GitBox <gi...@apache.org>.
wtlucy commented on pull request #104:
URL: https://github.com/apache/myfaces/pull/104#issuecomment-626333771
Nice job getting the annotation working. IMO `<scope>provided</scope>` would make more sense for this, but there must be some historical reason that this file only uses `<optional>true</optional>`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org