You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Qiang Zhang <zh...@zte.com.cn> on 2017/03/07 06:23:28 UTC
Review Request 57363: Log should be changed to info level
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57363/
-----------------------------------------------------------
Review request for ranger, Don Bosco Durai and Colm O hEigeartaigh.
Bugs: RANGER-1424
https://issues.apache.org/jira/browse/RANGER-1424
Repository: ranger
Description
-------
Path:\ranger\ugsync\src\main\java\org\apache\ranger\usergroupsync\usergroupsync.java
It should be LOG.info("Shutting down the UserGroupSync thread");
public void run() {
try {
...
}
catch(Throwable t) {
LOG.error("UserGroupSync thread got an error", t);
}
finally {
LOG.error("Shutting down the UserGroupSync thread");
}
}
Diffs
-----
ugsync/src/main/java/org/apache/ranger/usergroupsync/UserGroupSync.java e57247a
Diff: https://reviews.apache.org/r/57363/diff/1/
Testing
-------
Thanks,
Qiang Zhang
Re: Review Request 57363: Log should be changed to info level
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57363/#review168105
-----------------------------------------------------------
Ship it!
Ship It!
- Colm O hEigeartaigh
On March 7, 2017, 6:23 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57363/
> -----------------------------------------------------------
>
> (Updated March 7, 2017, 6:23 a.m.)
>
>
> Review request for ranger, Don Bosco Durai and Colm O hEigeartaigh.
>
>
> Bugs: RANGER-1424
> https://issues.apache.org/jira/browse/RANGER-1424
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Path:\ranger\ugsync\src\main\java\org\apache\ranger\usergroupsync\usergroupsync.java
> It should be LOG.info("Shutting down the UserGroupSync thread");
> public void run() {
> try {
> ...
> }
> catch(Throwable t) {
> LOG.error("UserGroupSync thread got an error", t);
> }
> finally {
> LOG.error("Shutting down the UserGroupSync thread");
> }
> }
>
>
> Diffs
> -----
>
> ugsync/src/main/java/org/apache/ranger/usergroupsync/UserGroupSync.java e57247a
>
>
> Diff: https://reviews.apache.org/r/57363/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qiang Zhang
>
>