You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/02/05 00:09:18 UTC
[GitHub] [pulsar] yangl opened a new pull request #9487: update the "-cluster" parameter in the delete-cluster-metadata command to "--cluster"
yangl opened a new pull request #9487:
URL: https://github.com/apache/pulsar/pull/9487
### Motivation
* change the **-cluster** parameter in the delete-cluster-metadata command to **--cluster** for this parameter exist short name **-c** .
### Modifications
* update the **-cluster** parameter to **--cluster**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yangl commented on pull request #9487: update the "-cluster" parameter in the delete-cluster-metadata command to "--cluster"
Posted by GitBox <gi...@apache.org>.
yangl commented on pull request #9487:
URL: https://github.com/apache/pulsar/pull/9487#issuecomment-774348617
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap merged pull request #9487: update the "-cluster" parameter in the delete-cluster-metadata command to "--cluster"
Posted by GitBox <gi...@apache.org>.
zymap merged pull request #9487:
URL: https://github.com/apache/pulsar/pull/9487
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on a change in pull request #9487: update the "-cluster" parameter in the delete-cluster-metadata command to "--cluster"
Posted by GitBox <gi...@apache.org>.
zymap commented on a change in pull request #9487:
URL: https://github.com/apache/pulsar/pull/9487#discussion_r570646041
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/PulsarClusterMetadataTeardown.java
##########
@@ -55,7 +55,7 @@
}, description = "Local zookeeper session timeout ms")
private int zkSessionTimeoutMillis = 30000;
- @Parameter(names = { "-c", "-cluster" }, description = "Cluster name")
+ @Parameter(names = { "-c", "--cluster" }, description = "Cluster name")
Review comment:
I would suggest keeping the old way in case there already has people used to deploy their cluster. We can just add the new name to it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yangl commented on a change in pull request #9487: update the "-cluster" parameter in the delete-cluster-metadata command to "--cluster"
Posted by GitBox <gi...@apache.org>.
yangl commented on a change in pull request #9487:
URL: https://github.com/apache/pulsar/pull/9487#discussion_r570670333
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/PulsarClusterMetadataTeardown.java
##########
@@ -55,7 +55,7 @@
}, description = "Local zookeeper session timeout ms")
private int zkSessionTimeoutMillis = 30000;
- @Parameter(names = { "-c", "-cluster" }, description = "Cluster name")
+ @Parameter(names = { "-c", "--cluster" }, description = "Cluster name")
Review comment:
Got, so add the new `--cluster`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on a change in pull request #9487: update the "-cluster" parameter in the delete-cluster-metadata command to "--cluster"
Posted by GitBox <gi...@apache.org>.
zymap commented on a change in pull request #9487:
URL: https://github.com/apache/pulsar/pull/9487#discussion_r570646041
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/PulsarClusterMetadataTeardown.java
##########
@@ -55,7 +55,7 @@
}, description = "Local zookeeper session timeout ms")
private int zkSessionTimeoutMillis = 30000;
- @Parameter(names = { "-c", "-cluster" }, description = "Cluster name")
+ @Parameter(names = { "-c", "--cluster" }, description = "Cluster name")
Review comment:
I would suggest keeping the old way in case there already has people used to deploy their cluster. We can just add the new name to it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yangl commented on a change in pull request #9487: update the "-cluster" parameter in the delete-cluster-metadata command to "--cluster"
Posted by GitBox <gi...@apache.org>.
yangl commented on a change in pull request #9487:
URL: https://github.com/apache/pulsar/pull/9487#discussion_r570670333
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/PulsarClusterMetadataTeardown.java
##########
@@ -55,7 +55,7 @@
}, description = "Local zookeeper session timeout ms")
private int zkSessionTimeoutMillis = 30000;
- @Parameter(names = { "-c", "-cluster" }, description = "Cluster name")
+ @Parameter(names = { "-c", "--cluster" }, description = "Cluster name")
Review comment:
Got, so add the new `--cluster`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org