You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "ijuma (via GitHub)" <gi...@apache.org> on 2023/06/19 15:17:51 UTC

[GitHub] [kafka] ijuma commented on a diff in pull request #13840: MINOR: Upgrade Scala for Java 20/21 support

ijuma commented on code in PR #13840:
URL: https://github.com/apache/kafka/pull/13840#discussion_r1234197390


##########
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##########
@@ -2499,15 +2499,16 @@ class ReplicaManagerTest {
                                                          time: Time,
                                                          threadNamePrefix: Option[String],
                                                          replicationQuotaManager: ReplicationQuotaManager): ReplicaFetcherManager = {
+        val rm = this

Review Comment:
   It doesn't make a difference since it's before the scope of the inner class of `ReplicaFetcherManager` is created, but I made this change for clarity.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org