You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/09 23:08:58 UTC

[GitHub] [beam] kennknowles commented on pull request #21783: Eliminate nullness errors in KafkaIO

kennknowles commented on PR #21783:
URL: https://github.com/apache/beam/pull/21783#issuecomment-1151700512

   R: @johnjcasey 
   
   We discussed some cases.
   
   This one I did a lot more "just add an assertion" style fixes, whereas usually I like to refactor things to eliminate the possibility of any error occurring. If you can spot places where it simply doesn't make sense to have a nullable field, please comment.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org