You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "paleolimbot (via GitHub)" <gi...@apache.org> on 2024/09/10 20:47:42 UTC
[PR] feat(c/driver/postgresql): Implement ingestion of list types for PostgreSQL [arrow-adbc]
paleolimbot opened a new pull request, #2153:
URL: https://github.com/apache/arrow-adbc/pull/2153
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(c/driver/postgresql): Implement ingestion of list types for PostgreSQL [arrow-adbc]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot merged PR #2153:
URL: https://github.com/apache/arrow-adbc/pull/2153
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(c/driver/postgresql): Implement ingestion of list types for PostgreSQL [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #2153:
URL: https://github.com/apache/arrow-adbc/pull/2153#discussion_r1755941450
##########
c/driver/postgresql/postgres_type.h:
##########
@@ -183,6 +183,26 @@ class PostgresType {
const std::string& field_name() const { return field_name_; }
int64_t n_children() const { return static_cast<int64_t>(children_.size()); }
const PostgresType& child(int64_t i) const { return children_[i]; }
+ const std::string create_table_name() const {
Review Comment:
Should this be named TypeName or something? Not table name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org