You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/07 22:20:13 UTC
[GitHub] [spark] gengliangwang opened a new pull request, #38542: Revert "[SPARK-38550][SQL][CORE] Use a disk-based store to save more debug information for live UI"
gengliangwang opened a new pull request, #38542:
URL: https://github.com/apache/spark/pull/38542
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Revert https://github.com/apache/spark/commit/4274fb8806c25519cac829d00b01132fe08c0cac
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
I am starting a new project for storing live UI data in disk-based KVStore for higher UI retentions(e.g. storing more than 1000 SQL queries in live UI).
The new approach will be better than https://github.com/apache/spark/commit/4274fb8806c25519cac829d00b01132fe08c0cac . The new configurations and listeners won't be needed. ThusI am having a revert before starting my project.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No, it is not released yet.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
CI tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #38542: Revert "[SPARK-38550][SQL][CORE] Use a disk-based store to save more debug information for live UI"
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on PR #38542:
URL: https://github.com/apache/spark/pull/38542#issuecomment-1308062914
Since both @linhongliu-db and @cloud-fan agreed on the revert, I will merge this one to make the review of https://github.com/apache/spark/pull/38567 a lot easier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #38542: Revert "[SPARK-38550][SQL][CORE] Use a disk-based store to save more debug information for live UI"
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #38542:
URL: https://github.com/apache/spark/pull/38542#issuecomment-1306499629
Hi, @gengliangwang . You can make a PR with two commits (this reverting and your PR).
Since this is for Apache Spark 3.4, we have enough time. Let's not hurry to merge this as @mridulm advised.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #38542: Revert "[SPARK-38550][SQL][CORE] Use a disk-based store to save more debug information for live UI"
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on PR #38542:
URL: https://github.com/apache/spark/pull/38542#issuecomment-1306573497
@dongjoon-hyun sure, no problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #38542: Revert "[SPARK-38550][SQL][CORE] Use a disk-based store to save more debug information for live UI"
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on PR #38542:
URL: https://github.com/apache/spark/pull/38542#issuecomment-1306425272
@mridulm There is no full prototype. I will send out a PR very soon.
I did some benchmarks, it showed using Protobuf as serialization can speed up the read/write 3~4 times compared to the current implementation. Thus, we can use RocksDB as the storage layer, similar to the current `InMemoryStore`.
I have to revert this one for removing the duplicated `diskStore` in https://github.com/apache/spark/commit/4274fb8806c25519cac829d00b01132fe08c0cac#diff-0cd94c36f45f50f513aeda6504fda0545270b05e105191131b601eb12b8a656bR42
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang closed pull request #38542: Revert "[SPARK-38550][SQL][CORE] Use a disk-based store to save more debug information for live UI"
Posted by GitBox <gi...@apache.org>.
gengliangwang closed pull request #38542: Revert "[SPARK-38550][SQL][CORE] Use a disk-based store to save more debug information for live UI"
URL: https://github.com/apache/spark/pull/38542
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #38542: Revert "[SPARK-38550][SQL][CORE] Use a disk-based store to save more debug information for live UI"
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on PR #38542:
URL: https://github.com/apache/spark/pull/38542#issuecomment-1306306110
cc @linhongliu-db @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #38542: Revert "[SPARK-38550][SQL][CORE] Use a disk-based store to save more debug information for live UI"
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #38542:
URL: https://github.com/apache/spark/pull/38542#issuecomment-1306667892
> @LuciferYang I didn't check that. Protobuf is mature(Spark Connect is also using Protobuf), and the result is good enough.
Got it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #38542: Revert "[SPARK-38550][SQL][CORE] Use a disk-based store to save more debug information for live UI"
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #38542:
URL: https://github.com/apache/spark/pull/38542#issuecomment-1306635799
> @mridulm There is no full prototype. I will send out a PR soon. I did some benchmarks, it showed using Protobuf as serialization can speed up the read/write 3~4 times compared to the current implementation. Thus, we can use RocksDB as the storage layer, similar to the current `InMemoryStore`. I have to revert this one for removing the duplicated `diskStore` in [4274fb8#diff-0cd94c36f45f50f513aeda6504fda0545270b05e105191131b601eb12b8a656bR42](https://github.com/apache/spark/commit/4274fb8806c25519cac829d00b01132fe08c0cac#diff-0cd94c36f45f50f513aeda6504fda0545270b05e105191131b601eb12b8a656bR42)
@gengliangwang Have you compared `Protobuf` and `Flatbuffers`? From the official benchmark data, `Flatbuffers` may have better performance.
http://google.github.io/flatbuffers/flatbuffers_benchmarks.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mridulm commented on pull request #38542: Revert "[SPARK-38550][SQL][CORE] Use a disk-based store to save more debug information for live UI"
Posted by GitBox <gi...@apache.org>.
mridulm commented on PR #38542:
URL: https://github.com/apache/spark/pull/38542#issuecomment-1306412118
Do we have a prototype for the new approach ? Before we revert, would be good to understand what is replacing it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #38542: Revert "[SPARK-38550][SQL][CORE] Use a disk-based store to save more debug information for live UI"
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on PR #38542:
URL: https://github.com/apache/spark/pull/38542#issuecomment-1306667150
@LuciferYang I didn't check that. Protobuf is mature(Spark Connect is also using Protobuf), and the result is good enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #38542: Revert "[SPARK-38550][SQL][CORE] Use a disk-based store to save more debug information for live UI"
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on PR #38542:
URL: https://github.com/apache/spark/pull/38542#issuecomment-1307922530
FYI I have created https://github.com/apache/spark/pull/38567, which contains the reverting changes in this one.
Merging the revert of this one can make the review a lot easier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org