You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/01/14 02:53:45 UTC

[GitHub] [incubator-pinot] codecov-io commented on issue #4979: Update quota manager to reduce zk access

codecov-io commented on issue #4979: Update quota manager to reduce zk access
URL: https://github.com/apache/incubator-pinot/pull/4979#issuecomment-573975171
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4979?src=pr&el=h1) Report
   > Merging [#4979](https://codecov.io/gh/apache/incubator-pinot/pull/4979?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/e81e5303a2e6157bb3530c621c3b8ce748788a83?src=pr&el=desc) will **increase** coverage by `21%`.
   > The diff coverage is `32.43%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/4979/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/4979?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4979      +/-   ##
   ============================================
   + Coverage     36.35%   57.35%     +21%     
   - Complexity        0       12      +12     
   ============================================
     Files          1174     1174              
     Lines         62244    62268      +24     
     Branches       9148     9150       +2     
   ============================================
   + Hits          22627    35713   +13086     
   + Misses        37596    23877   -13719     
   - Partials       2021     2678     +657
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4979?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...quota/HelixExternalViewBasedQueryQuotaManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4979/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcXVlcnlxdW90YS9IZWxpeEV4dGVybmFsVmlld0Jhc2VkUXVlcnlRdW90YU1hbmFnZXIuamF2YQ==) | `61.98% <32.14%> (+24.56%)` | `0 <0> (ø)` | :arrow_down: |
   | [...ache/pinot/broker/queryquota/QueryQuotaConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4979/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcXVlcnlxdW90YS9RdWVyeVF1b3RhQ29uZmlnLmphdmE=) | `57.14% <33.33%> (+57.14%)` | `0 <0> (ø)` | :arrow_down: |
   | [...e/impl/dictionary/LongOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4979/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvTG9uZ09uSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `57.31% <0%> (-4.88%)` | `0% <0%> (ø)` | |
   | [...r/filter/predicate/PredicateEvaluatorProvider.java](https://codecov.io/gh/apache/incubator-pinot/pull/4979/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9maWx0ZXIvcHJlZGljYXRlL1ByZWRpY2F0ZUV2YWx1YXRvclByb3ZpZGVyLmphdmE=) | `52.17% <0%> (-4.35%)` | `0% <0%> (ø)` | |
   | [...ot/controller/helix/core/util/HelixSetupUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4979/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3V0aWwvSGVsaXhTZXR1cFV0aWxzLmphdmE=) | `88.75% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
   | [...impl/dictionary/DoubleOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4979/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRG91YmxlT25IZWFwTXV0YWJsZURpY3Rpb25hcnkuamF2YQ==) | `36.58% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
   | [...ces/PinotSegmentUploadDownloadRestletResource.java](https://codecov.io/gh/apache/incubator-pinot/pull/4979/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL1Bpbm90U2VnbWVudFVwbG9hZERvd25sb2FkUmVzdGxldFJlc291cmNlLmphdmE=) | `61.34% <0%> (+0.61%)` | `0% <0%> (ø)` | :arrow_down: |
   | [.../impl/dictionary/LongOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4979/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvTG9uZ09mZkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `64.51% <0%> (+1.07%)` | `0% <0%> (ø)` | :arrow_down: |
   | [...e/io/writer/impl/MutableOffHeapByteArrayStore.java](https://codecov.io/gh/apache/incubator-pinot/pull/4979/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pby93cml0ZXIvaW1wbC9NdXRhYmxlT2ZmSGVhcEJ5dGVBcnJheVN0b3JlLmphdmE=) | `85.71% <0%> (+1.09%)` | `0% <0%> (ø)` | :arrow_down: |
   | [...g/apache/pinot/common/request/InstanceRequest.java](https://codecov.io/gh/apache/incubator-pinot/pull/4979/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9JbnN0YW5jZVJlcXVlc3QuamF2YQ==) | `28.83% <0%> (+1.14%)` | `0% <0%> (ø)` | :arrow_down: |
   | ... and [586 more](https://codecov.io/gh/apache/incubator-pinot/pull/4979/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4979?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4979?src=pr&el=footer). Last update [e81e530...c2733c5](https://codecov.io/gh/apache/incubator-pinot/pull/4979?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org