You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/09/30 10:17:30 UTC
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6790: kvm: fix backup volume snapshot fails on RBD storage
DaanHoogland commented on code in PR #6790:
URL: https://github.com/apache/cloudstack/pull/6790#discussion_r984436481
##########
plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/qemu/QemuImageOptions.java:
##########
@@ -56,13 +62,15 @@ public QemuImageOptions(QemuImg.PhysicalDiskFormat format, String filePath, Stri
}
}
if (format != null) {
- params.put("driver", format.toString());
+ params.put(DRIVER, format.toString());
+ this.format = format;
}
Review Comment:
we can change this to
```suggestion
setFormat(format);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org