[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #6135: Substrait: Fix incorrect join key fields (indices) when same table is being used more than once

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #6135:
URL: https://github.com/apache/arrow-datafusion/pull/6135#discussion_r1225799980


##########
datafusion/substrait/src/logical_plan/producer.rs:
##########
@@ -566,10 +581,33 @@ pub fn make_binary_op_scalar_func(
 }
 
 /// Convert DataFusion Expr to Substrait Rex
+///

Review Comment:
   👍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org