You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by sharad agarwal <sh...@apache.org> on 2014/12/24 07:52:58 UTC
Review Request 29391: Lens-153 Add example execution runner
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29391/
-----------------------------------------------------------
Review request for lens, Jaideep dhok and Suma Shivaprasad.
Repository: lens
Description
-------
Lens-153 Add example execution runner
Diffs
-----
lens-client-dist/src/main/assembly/client-dist.xml 8190720
lens-docker/lens-test/Dockerfile f35c0ff
lens-docker/lens-test/lens-bootstrap.sh 23ed307
lens-ml-dist/LICENSE.txt PRE-CREATION
lens-ml-dist/pom.xml PRE-CREATION
lens-ml-dist/src/main/assembly/ml-dist.xml PRE-CREATION
lens-ml-dist/src/site/apt/index.apt PRE-CREATION
lens-ml-lib/data/naive_bayes/ml.properties PRE-CREATION
lens-ml-lib/data/naive_bayes/naive_bayes_train.data dfb9ccd
lens-ml-lib/data/naive_bayes/test.data PRE-CREATION
lens-ml-lib/data/naive_bayes/train.data PRE-CREATION
lens-ml-lib/src/main/java/org/apache/lens/client/LensMLClient.java 5c5bc65
lens-ml-lib/src/main/java/org/apache/lens/ml/MLRunner.java PRE-CREATION
lens-ml-lib/src/main/java/org/apache/lens/ml/task/MLTask.java d2bed0a
lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLResource.java d1318fc
lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLRunner.java PRE-CREATION
lens-ml-lib/tools/scripts/lens-ml-classpath.sh PRE-CREATION
pom.xml 9265a77
tools/conf-pseudo-distr/client/lens-client-site.xml 706e356
tools/conf-pseudo-distr/server/lens-site.xml 8110ab8
tools/scripts/lens-config.sh 8bd9013
tools/scripts/lens-run-class.sh PRE-CREATION
Diff: https://reviews.apache.org/r/29391/diff/
Testing
-------
Thanks,
sharad agarwal
Re: Review Request 29391: Lens-153 Add example execution runner
Posted by Jaideep dhok <ja...@inmobi.com>.
> On Dec. 24, 2014, 10:11 a.m., Suma Shivaprasad wrote:
> > lens-ml-lib/tools/scripts/lens-ml-classpath.sh, line 45
> > <https://reviews.apache.org/r/29391/diff/1/?file=800118#file800118line45>
> >
> > do we need any spark jars in classpath?
Spark jars are not required since examples will run as a client to lens server. Lens server should have Spark in its classpath.
- Jaideep
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29391/#review66022
-----------------------------------------------------------
On Dec. 24, 2014, 6:54 a.m., sharad agarwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29391/
> -----------------------------------------------------------
>
> (Updated Dec. 24, 2014, 6:54 a.m.)
>
>
> Review request for lens, Jaideep dhok and Suma Shivaprasad.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Lens-153 Add example execution runner
>
>
> Diffs
> -----
>
> lens-client-dist/src/main/assembly/client-dist.xml 8190720
> lens-docker/lens-test/Dockerfile f35c0ff
> lens-docker/lens-test/lens-bootstrap.sh 23ed307
> lens-ml-dist/LICENSE.txt PRE-CREATION
> lens-ml-dist/pom.xml PRE-CREATION
> lens-ml-dist/src/main/assembly/ml-dist.xml PRE-CREATION
> lens-ml-dist/src/site/apt/index.apt PRE-CREATION
> lens-ml-lib/data/naive_bayes/ml.properties PRE-CREATION
> lens-ml-lib/data/naive_bayes/naive_bayes_train.data dfb9ccd
> lens-ml-lib/data/naive_bayes/test.data PRE-CREATION
> lens-ml-lib/data/naive_bayes/train.data PRE-CREATION
> lens-ml-lib/src/main/java/org/apache/lens/client/LensMLClient.java 5c5bc65
> lens-ml-lib/src/main/java/org/apache/lens/ml/MLRunner.java PRE-CREATION
> lens-ml-lib/src/main/java/org/apache/lens/ml/task/MLTask.java d2bed0a
> lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLResource.java d1318fc
> lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLRunner.java PRE-CREATION
> lens-ml-lib/tools/scripts/lens-ml-classpath.sh PRE-CREATION
> pom.xml 9265a77
> tools/conf-pseudo-distr/client/lens-client-site.xml 706e356
> tools/conf-pseudo-distr/server/lens-site.xml 8110ab8
> tools/scripts/lens-config.sh 8bd9013
> tools/scripts/lens-run-class.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29391/diff/
>
>
> Testing
> -------
>
> - Ran the TestMLRunner
> - build and ran the docker script
>
>
> Thanks,
>
> sharad agarwal
>
>
Re: Review Request 29391: Lens-153 Add example execution runner
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29391/#review66022
-----------------------------------------------------------
lens-ml-lib/src/main/java/org/apache/lens/ml/MLRunner.java
<https://reviews.apache.org/r/29391/#comment109373>
Should we move this to ml/examples?
lens-ml-lib/tools/scripts/lens-ml-classpath.sh
<https://reviews.apache.org/r/29391/#comment109374>
do we need any spark jars in classpath?
- Suma Shivaprasad
On Dec. 24, 2014, 6:54 a.m., sharad agarwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29391/
> -----------------------------------------------------------
>
> (Updated Dec. 24, 2014, 6:54 a.m.)
>
>
> Review request for lens, Jaideep dhok and Suma Shivaprasad.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Lens-153 Add example execution runner
>
>
> Diffs
> -----
>
> lens-client-dist/src/main/assembly/client-dist.xml 8190720
> lens-docker/lens-test/Dockerfile f35c0ff
> lens-docker/lens-test/lens-bootstrap.sh 23ed307
> lens-ml-dist/LICENSE.txt PRE-CREATION
> lens-ml-dist/pom.xml PRE-CREATION
> lens-ml-dist/src/main/assembly/ml-dist.xml PRE-CREATION
> lens-ml-dist/src/site/apt/index.apt PRE-CREATION
> lens-ml-lib/data/naive_bayes/ml.properties PRE-CREATION
> lens-ml-lib/data/naive_bayes/naive_bayes_train.data dfb9ccd
> lens-ml-lib/data/naive_bayes/test.data PRE-CREATION
> lens-ml-lib/data/naive_bayes/train.data PRE-CREATION
> lens-ml-lib/src/main/java/org/apache/lens/client/LensMLClient.java 5c5bc65
> lens-ml-lib/src/main/java/org/apache/lens/ml/MLRunner.java PRE-CREATION
> lens-ml-lib/src/main/java/org/apache/lens/ml/task/MLTask.java d2bed0a
> lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLResource.java d1318fc
> lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLRunner.java PRE-CREATION
> lens-ml-lib/tools/scripts/lens-ml-classpath.sh PRE-CREATION
> pom.xml 9265a77
> tools/conf-pseudo-distr/client/lens-client-site.xml 706e356
> tools/conf-pseudo-distr/server/lens-site.xml 8110ab8
> tools/scripts/lens-config.sh 8bd9013
> tools/scripts/lens-run-class.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29391/diff/
>
>
> Testing
> -------
>
> - Ran the TestMLRunner
> - build and ran the docker script
>
>
> Thanks,
>
> sharad agarwal
>
>
Re: Review Request 29391: Lens-153 Add example execution runner
Posted by Jaideep dhok <ja...@inmobi.com>.
> On Dec. 24, 2014, 7:58 a.m., Amareshwari Sriramadasu wrote:
> > tools/scripts/lens-run-class.sh, line 101
> > <https://reviews.apache.org/r/29391/diff/1/?file=800123#file800123line101>
> >
> > Are hadoop jars required for this utility runner?
@Amareshwari, hadoop jars might be required for HiveConf
- Jaideep
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29391/#review66017
-----------------------------------------------------------
On Dec. 24, 2014, 6:54 a.m., sharad agarwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29391/
> -----------------------------------------------------------
>
> (Updated Dec. 24, 2014, 6:54 a.m.)
>
>
> Review request for lens, Jaideep dhok and Suma Shivaprasad.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Lens-153 Add example execution runner
>
>
> Diffs
> -----
>
> lens-client-dist/src/main/assembly/client-dist.xml 8190720
> lens-docker/lens-test/Dockerfile f35c0ff
> lens-docker/lens-test/lens-bootstrap.sh 23ed307
> lens-ml-dist/LICENSE.txt PRE-CREATION
> lens-ml-dist/pom.xml PRE-CREATION
> lens-ml-dist/src/main/assembly/ml-dist.xml PRE-CREATION
> lens-ml-dist/src/site/apt/index.apt PRE-CREATION
> lens-ml-lib/data/naive_bayes/ml.properties PRE-CREATION
> lens-ml-lib/data/naive_bayes/naive_bayes_train.data dfb9ccd
> lens-ml-lib/data/naive_bayes/test.data PRE-CREATION
> lens-ml-lib/data/naive_bayes/train.data PRE-CREATION
> lens-ml-lib/src/main/java/org/apache/lens/client/LensMLClient.java 5c5bc65
> lens-ml-lib/src/main/java/org/apache/lens/ml/MLRunner.java PRE-CREATION
> lens-ml-lib/src/main/java/org/apache/lens/ml/task/MLTask.java d2bed0a
> lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLResource.java d1318fc
> lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLRunner.java PRE-CREATION
> lens-ml-lib/tools/scripts/lens-ml-classpath.sh PRE-CREATION
> pom.xml 9265a77
> tools/conf-pseudo-distr/client/lens-client-site.xml 706e356
> tools/conf-pseudo-distr/server/lens-site.xml 8110ab8
> tools/scripts/lens-config.sh 8bd9013
> tools/scripts/lens-run-class.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29391/diff/
>
>
> Testing
> -------
>
> - Ran the TestMLRunner
> - build and ran the docker script
>
>
> Thanks,
>
> sharad agarwal
>
>
Re: Review Request 29391: Lens-153 Add example execution runner
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29391/#review66017
-----------------------------------------------------------
Can you take care of trimming trialing white spaces?
lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLResource.java
<https://reviews.apache.org/r/29391/#comment109364>
This port would conflict with default port, if a lens server is already running on the machine.
lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLRunner.java
<https://reviews.apache.org/r/29391/#comment109366>
Same again. Conflicts with default port, can we use a different port?
tools/scripts/lens-run-class.sh
<https://reviews.apache.org/r/29391/#comment109365>
Are hadoop jars required for this utility runner?
- Amareshwari Sriramadasu
On Dec. 24, 2014, 6:54 a.m., sharad agarwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29391/
> -----------------------------------------------------------
>
> (Updated Dec. 24, 2014, 6:54 a.m.)
>
>
> Review request for lens, Jaideep dhok and Suma Shivaprasad.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Lens-153 Add example execution runner
>
>
> Diffs
> -----
>
> lens-client-dist/src/main/assembly/client-dist.xml 8190720
> lens-docker/lens-test/Dockerfile f35c0ff
> lens-docker/lens-test/lens-bootstrap.sh 23ed307
> lens-ml-dist/LICENSE.txt PRE-CREATION
> lens-ml-dist/pom.xml PRE-CREATION
> lens-ml-dist/src/main/assembly/ml-dist.xml PRE-CREATION
> lens-ml-dist/src/site/apt/index.apt PRE-CREATION
> lens-ml-lib/data/naive_bayes/ml.properties PRE-CREATION
> lens-ml-lib/data/naive_bayes/naive_bayes_train.data dfb9ccd
> lens-ml-lib/data/naive_bayes/test.data PRE-CREATION
> lens-ml-lib/data/naive_bayes/train.data PRE-CREATION
> lens-ml-lib/src/main/java/org/apache/lens/client/LensMLClient.java 5c5bc65
> lens-ml-lib/src/main/java/org/apache/lens/ml/MLRunner.java PRE-CREATION
> lens-ml-lib/src/main/java/org/apache/lens/ml/task/MLTask.java d2bed0a
> lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLResource.java d1318fc
> lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLRunner.java PRE-CREATION
> lens-ml-lib/tools/scripts/lens-ml-classpath.sh PRE-CREATION
> pom.xml 9265a77
> tools/conf-pseudo-distr/client/lens-client-site.xml 706e356
> tools/conf-pseudo-distr/server/lens-site.xml 8110ab8
> tools/scripts/lens-config.sh 8bd9013
> tools/scripts/lens-run-class.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29391/diff/
>
>
> Testing
> -------
>
> - Ran the TestMLRunner
> - build and ran the docker script
>
>
> Thanks,
>
> sharad agarwal
>
>
Re: Review Request 29391: Lens-153 Add example execution runner
Posted by sharad agarwal <sh...@apache.org>.
> On Feb. 1, 2015, 7:15 a.m., Jaideep dhok wrote:
> > Apart from whitespace issues etc, patch looks ok to me.
> >
> > @Sharad is this still blocked by the UDF registration issue? If we want to target this for the release, I will put up a patch for that soon.
yes, UDF registration is blocking this. would be nice to get that and this in for 2.0.
- sharad
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29391/#review70524
-----------------------------------------------------------
On Jan. 30, 2015, 2:48 p.m., sharad agarwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29391/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2015, 2:48 p.m.)
>
>
> Review request for lens, Jaideep dhok and Suma Shivaprasad.
>
>
> Bugs: lens-153
> https://issues.apache.org/jira/browse/lens-153
>
>
> Repository: lens
>
>
> Description
> -------
>
> Lens-153 Add example execution runner
>
>
> Diffs
> -----
>
> lens-client-dist/src/main/assembly/client-dist.xml 8190720
> lens-docker/lens-test/Dockerfile f35c0ff
> lens-docker/lens-test/lens-bootstrap.sh 23ed307
> lens-ml-dist/LICENSE.txt PRE-CREATION
> lens-ml-dist/pom.xml PRE-CREATION
> lens-ml-dist/src/main/assembly/ml-dist.xml PRE-CREATION
> lens-ml-dist/src/site/apt/index.apt PRE-CREATION
> lens-ml-lib/data/naive_bayes/ml.properties PRE-CREATION
> lens-ml-lib/data/naive_bayes/naive_bayes_train.data dfb9ccd
> lens-ml-lib/data/naive_bayes/test.data PRE-CREATION
> lens-ml-lib/data/naive_bayes/train.data PRE-CREATION
> lens-ml-lib/src/main/java/org/apache/lens/client/LensMLClient.java 5c5bc65
> lens-ml-lib/src/main/java/org/apache/lens/ml/MLRunner.java PRE-CREATION
> lens-ml-lib/src/main/java/org/apache/lens/ml/task/MLTask.java d2bed0a
> lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLResource.java d1318fc
> lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLRunner.java PRE-CREATION
> lens-ml-lib/tools/scripts/lens-ml-classpath.sh PRE-CREATION
> pom.xml 9265a77
> tools/conf-pseudo-distr/client/lens-client-site.xml 706e356
> tools/conf-pseudo-distr/server/lens-site.xml 8110ab8
> tools/scripts/lens-config.sh 8bd9013
> tools/scripts/lens-run-class.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29391/diff/
>
>
> Testing
> -------
>
> - Ran the TestMLRunner
> - build and ran the docker script
>
>
> Thanks,
>
> sharad agarwal
>
>
Re: Review Request 29391: Lens-153 Add example execution runner
Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29391/#review70524
-----------------------------------------------------------
Apart from whitespace issues etc, patch looks ok to me.
@Sharad is this still blocked by the UDF registration issue? If we want to target this for the release, I will put up a patch for that soon.
- Jaideep dhok
On Jan. 30, 2015, 2:48 p.m., sharad agarwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29391/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2015, 2:48 p.m.)
>
>
> Review request for lens, Jaideep dhok and Suma Shivaprasad.
>
>
> Bugs: lens-153
> https://issues.apache.org/jira/browse/lens-153
>
>
> Repository: lens
>
>
> Description
> -------
>
> Lens-153 Add example execution runner
>
>
> Diffs
> -----
>
> lens-client-dist/src/main/assembly/client-dist.xml 8190720
> lens-docker/lens-test/Dockerfile f35c0ff
> lens-docker/lens-test/lens-bootstrap.sh 23ed307
> lens-ml-dist/LICENSE.txt PRE-CREATION
> lens-ml-dist/pom.xml PRE-CREATION
> lens-ml-dist/src/main/assembly/ml-dist.xml PRE-CREATION
> lens-ml-dist/src/site/apt/index.apt PRE-CREATION
> lens-ml-lib/data/naive_bayes/ml.properties PRE-CREATION
> lens-ml-lib/data/naive_bayes/naive_bayes_train.data dfb9ccd
> lens-ml-lib/data/naive_bayes/test.data PRE-CREATION
> lens-ml-lib/data/naive_bayes/train.data PRE-CREATION
> lens-ml-lib/src/main/java/org/apache/lens/client/LensMLClient.java 5c5bc65
> lens-ml-lib/src/main/java/org/apache/lens/ml/MLRunner.java PRE-CREATION
> lens-ml-lib/src/main/java/org/apache/lens/ml/task/MLTask.java d2bed0a
> lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLResource.java d1318fc
> lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLRunner.java PRE-CREATION
> lens-ml-lib/tools/scripts/lens-ml-classpath.sh PRE-CREATION
> pom.xml 9265a77
> tools/conf-pseudo-distr/client/lens-client-site.xml 706e356
> tools/conf-pseudo-distr/server/lens-site.xml 8110ab8
> tools/scripts/lens-config.sh 8bd9013
> tools/scripts/lens-run-class.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29391/diff/
>
>
> Testing
> -------
>
> - Ran the TestMLRunner
> - build and ran the docker script
>
>
> Thanks,
>
> sharad agarwal
>
>
Re: Review Request 29391: Lens-153 Add example execution runner
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29391/#review70499
-----------------------------------------------------------
lens-ml-dist/LICENSE.txt
<https://reviews.apache.org/r/29391/#comment115711>
Can we name the file LICENSE instead of LICENSE.txt?
lens-ml-dist/pom.xml
<https://reviews.apache.org/r/29391/#comment115713>
Can we remove these trailing white spaces?
lens-ml-dist/pom.xml
<https://reviews.apache.org/r/29391/#comment115712>
version should be 2.0.0-incubating-SNAPSHOT
tools/conf-pseudo-distr/server/lens-site.xml
<https://reviews.apache.org/r/29391/#comment115714>
Property is added twice
- Amareshwari Sriramadasu
On Jan. 30, 2015, 2:48 p.m., sharad agarwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29391/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2015, 2:48 p.m.)
>
>
> Review request for lens, Jaideep dhok and Suma Shivaprasad.
>
>
> Bugs: lens-153
> https://issues.apache.org/jira/browse/lens-153
>
>
> Repository: lens
>
>
> Description
> -------
>
> Lens-153 Add example execution runner
>
>
> Diffs
> -----
>
> lens-client-dist/src/main/assembly/client-dist.xml 8190720
> lens-docker/lens-test/Dockerfile f35c0ff
> lens-docker/lens-test/lens-bootstrap.sh 23ed307
> lens-ml-dist/LICENSE.txt PRE-CREATION
> lens-ml-dist/pom.xml PRE-CREATION
> lens-ml-dist/src/main/assembly/ml-dist.xml PRE-CREATION
> lens-ml-dist/src/site/apt/index.apt PRE-CREATION
> lens-ml-lib/data/naive_bayes/ml.properties PRE-CREATION
> lens-ml-lib/data/naive_bayes/naive_bayes_train.data dfb9ccd
> lens-ml-lib/data/naive_bayes/test.data PRE-CREATION
> lens-ml-lib/data/naive_bayes/train.data PRE-CREATION
> lens-ml-lib/src/main/java/org/apache/lens/client/LensMLClient.java 5c5bc65
> lens-ml-lib/src/main/java/org/apache/lens/ml/MLRunner.java PRE-CREATION
> lens-ml-lib/src/main/java/org/apache/lens/ml/task/MLTask.java d2bed0a
> lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLResource.java d1318fc
> lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLRunner.java PRE-CREATION
> lens-ml-lib/tools/scripts/lens-ml-classpath.sh PRE-CREATION
> pom.xml 9265a77
> tools/conf-pseudo-distr/client/lens-client-site.xml 706e356
> tools/conf-pseudo-distr/server/lens-site.xml 8110ab8
> tools/scripts/lens-config.sh 8bd9013
> tools/scripts/lens-run-class.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29391/diff/
>
>
> Testing
> -------
>
> - Ran the TestMLRunner
> - build and ran the docker script
>
>
> Thanks,
>
> sharad agarwal
>
>
Re: Review Request 29391: Lens-153 Add example execution runner
Posted by sharad agarwal <sh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29391/
-----------------------------------------------------------
(Updated Jan. 30, 2015, 2:48 p.m.)
Review request for lens, Jaideep dhok and Suma Shivaprasad.
Bugs: lens-153
https://issues.apache.org/jira/browse/lens-153
Repository: lens
Description
-------
Lens-153 Add example execution runner
Diffs
-----
lens-client-dist/src/main/assembly/client-dist.xml 8190720
lens-docker/lens-test/Dockerfile f35c0ff
lens-docker/lens-test/lens-bootstrap.sh 23ed307
lens-ml-dist/LICENSE.txt PRE-CREATION
lens-ml-dist/pom.xml PRE-CREATION
lens-ml-dist/src/main/assembly/ml-dist.xml PRE-CREATION
lens-ml-dist/src/site/apt/index.apt PRE-CREATION
lens-ml-lib/data/naive_bayes/ml.properties PRE-CREATION
lens-ml-lib/data/naive_bayes/naive_bayes_train.data dfb9ccd
lens-ml-lib/data/naive_bayes/test.data PRE-CREATION
lens-ml-lib/data/naive_bayes/train.data PRE-CREATION
lens-ml-lib/src/main/java/org/apache/lens/client/LensMLClient.java 5c5bc65
lens-ml-lib/src/main/java/org/apache/lens/ml/MLRunner.java PRE-CREATION
lens-ml-lib/src/main/java/org/apache/lens/ml/task/MLTask.java d2bed0a
lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLResource.java d1318fc
lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLRunner.java PRE-CREATION
lens-ml-lib/tools/scripts/lens-ml-classpath.sh PRE-CREATION
pom.xml 9265a77
tools/conf-pseudo-distr/client/lens-client-site.xml 706e356
tools/conf-pseudo-distr/server/lens-site.xml 8110ab8
tools/scripts/lens-config.sh 8bd9013
tools/scripts/lens-run-class.sh PRE-CREATION
Diff: https://reviews.apache.org/r/29391/diff/
Testing
-------
- Ran the TestMLRunner
- build and ran the docker script
Thanks,
sharad agarwal
Re: Review Request 29391: Lens-153 Add example execution runner
Posted by sharad agarwal <sh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29391/
-----------------------------------------------------------
(Updated Jan. 30, 2015, 1:51 p.m.)
Review request for lens, Jaideep dhok and Suma Shivaprasad.
Bugs: lens-153
https://issues.apache.org/jira/browse/lens-153
Repository: lens
Description
-------
Lens-153 Add example execution runner
Diffs
-----
lens-client-dist/src/main/assembly/client-dist.xml 8190720
lens-docker/lens-test/Dockerfile f35c0ff
lens-docker/lens-test/lens-bootstrap.sh 23ed307
lens-ml-dist/LICENSE.txt PRE-CREATION
lens-ml-dist/pom.xml PRE-CREATION
lens-ml-dist/src/main/assembly/ml-dist.xml PRE-CREATION
lens-ml-dist/src/site/apt/index.apt PRE-CREATION
lens-ml-lib/data/naive_bayes/ml.properties PRE-CREATION
lens-ml-lib/data/naive_bayes/naive_bayes_train.data dfb9ccd
lens-ml-lib/data/naive_bayes/test.data PRE-CREATION
lens-ml-lib/data/naive_bayes/train.data PRE-CREATION
lens-ml-lib/src/main/java/org/apache/lens/client/LensMLClient.java 5c5bc65
lens-ml-lib/src/main/java/org/apache/lens/ml/MLRunner.java PRE-CREATION
lens-ml-lib/src/main/java/org/apache/lens/ml/task/MLTask.java d2bed0a
lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLResource.java d1318fc
lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLRunner.java PRE-CREATION
lens-ml-lib/tools/scripts/lens-ml-classpath.sh PRE-CREATION
pom.xml 9265a77
tools/conf-pseudo-distr/client/lens-client-site.xml 706e356
tools/conf-pseudo-distr/server/lens-site.xml 8110ab8
tools/scripts/lens-config.sh 8bd9013
tools/scripts/lens-run-class.sh PRE-CREATION
Diff: https://reviews.apache.org/r/29391/diff/
Testing
-------
- Ran the TestMLRunner
- build and ran the docker script
Thanks,
sharad agarwal
Re: Review Request 29391: Lens-153 Add example execution runner
Posted by sharad agarwal <sh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29391/
-----------------------------------------------------------
(Updated Jan. 30, 2015, 1:44 p.m.)
Review request for lens, Jaideep dhok and Suma Shivaprasad.
Bugs: lens-153
https://issues.apache.org/jira/browse/lens-153
Repository: lens
Description
-------
Lens-153 Add example execution runner
Diffs
-----
lens-client-dist/src/main/assembly/client-dist.xml 8190720
lens-docker/lens-test/Dockerfile f35c0ff
lens-docker/lens-test/lens-bootstrap.sh 23ed307
lens-ml-dist/LICENSE.txt PRE-CREATION
lens-ml-dist/pom.xml PRE-CREATION
lens-ml-dist/src/main/assembly/ml-dist.xml PRE-CREATION
lens-ml-dist/src/site/apt/index.apt PRE-CREATION
lens-ml-lib/data/naive_bayes/ml.properties PRE-CREATION
lens-ml-lib/data/naive_bayes/naive_bayes_train.data dfb9ccd
lens-ml-lib/data/naive_bayes/test.data PRE-CREATION
lens-ml-lib/data/naive_bayes/train.data PRE-CREATION
lens-ml-lib/src/main/java/org/apache/lens/client/LensMLClient.java 5c5bc65
lens-ml-lib/src/main/java/org/apache/lens/ml/MLRunner.java PRE-CREATION
lens-ml-lib/src/main/java/org/apache/lens/ml/task/MLTask.java d2bed0a
lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLResource.java d1318fc
lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLRunner.java PRE-CREATION
lens-ml-lib/tools/scripts/lens-ml-classpath.sh PRE-CREATION
pom.xml 9265a77
tools/conf-pseudo-distr/client/lens-client-site.xml 706e356
tools/conf-pseudo-distr/server/lens-site.xml 8110ab8
tools/scripts/lens-config.sh 8bd9013
tools/scripts/lens-run-class.sh PRE-CREATION
Diff: https://reviews.apache.org/r/29391/diff/
Testing
-------
- Ran the TestMLRunner
- build and ran the docker script
Thanks,
sharad agarwal
Re: Review Request 29391: Lens-153 Add example execution runner
Posted by sharad agarwal <sh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29391/
-----------------------------------------------------------
(Updated Jan. 30, 2015, 1:40 p.m.)
Review request for lens, Jaideep dhok and Suma Shivaprasad.
Bugs: lens-153
https://issues.apache.org/jira/browse/lens-153
Repository: lens
Description
-------
Lens-153 Add example execution runner
Diffs
-----
lens-client-dist/src/main/assembly/client-dist.xml 8190720
lens-docker/lens-test/Dockerfile f35c0ff
lens-docker/lens-test/lens-bootstrap.sh 23ed307
lens-ml-dist/LICENSE.txt PRE-CREATION
lens-ml-dist/pom.xml PRE-CREATION
lens-ml-dist/src/main/assembly/ml-dist.xml PRE-CREATION
lens-ml-dist/src/site/apt/index.apt PRE-CREATION
lens-ml-lib/data/naive_bayes/ml.properties PRE-CREATION
lens-ml-lib/data/naive_bayes/naive_bayes_train.data dfb9ccd
lens-ml-lib/data/naive_bayes/test.data PRE-CREATION
lens-ml-lib/data/naive_bayes/train.data PRE-CREATION
lens-ml-lib/src/main/java/org/apache/lens/client/LensMLClient.java 5c5bc65
lens-ml-lib/src/main/java/org/apache/lens/ml/MLRunner.java PRE-CREATION
lens-ml-lib/src/main/java/org/apache/lens/ml/task/MLTask.java d2bed0a
lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLResource.java d1318fc
lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLRunner.java PRE-CREATION
lens-ml-lib/tools/scripts/lens-ml-classpath.sh PRE-CREATION
pom.xml 9265a77
tools/conf-pseudo-distr/client/lens-client-site.xml 706e356
tools/conf-pseudo-distr/server/lens-site.xml 8110ab8
tools/scripts/lens-config.sh 8bd9013
tools/scripts/lens-run-class.sh PRE-CREATION
Diff: https://reviews.apache.org/r/29391/diff/
Testing
-------
- Ran the TestMLRunner
- build and ran the docker script
Thanks,
sharad agarwal
Re: Review Request 29391: Lens-153 Add example execution runner
Posted by sharad agarwal <sh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29391/
-----------------------------------------------------------
(Updated Dec. 24, 2014, 6:54 a.m.)
Review request for lens, Jaideep dhok and Suma Shivaprasad.
Repository: lens
Description
-------
Lens-153 Add example execution runner
Diffs
-----
lens-client-dist/src/main/assembly/client-dist.xml 8190720
lens-docker/lens-test/Dockerfile f35c0ff
lens-docker/lens-test/lens-bootstrap.sh 23ed307
lens-ml-dist/LICENSE.txt PRE-CREATION
lens-ml-dist/pom.xml PRE-CREATION
lens-ml-dist/src/main/assembly/ml-dist.xml PRE-CREATION
lens-ml-dist/src/site/apt/index.apt PRE-CREATION
lens-ml-lib/data/naive_bayes/ml.properties PRE-CREATION
lens-ml-lib/data/naive_bayes/naive_bayes_train.data dfb9ccd
lens-ml-lib/data/naive_bayes/test.data PRE-CREATION
lens-ml-lib/data/naive_bayes/train.data PRE-CREATION
lens-ml-lib/src/main/java/org/apache/lens/client/LensMLClient.java 5c5bc65
lens-ml-lib/src/main/java/org/apache/lens/ml/MLRunner.java PRE-CREATION
lens-ml-lib/src/main/java/org/apache/lens/ml/task/MLTask.java d2bed0a
lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLResource.java d1318fc
lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLRunner.java PRE-CREATION
lens-ml-lib/tools/scripts/lens-ml-classpath.sh PRE-CREATION
pom.xml 9265a77
tools/conf-pseudo-distr/client/lens-client-site.xml 706e356
tools/conf-pseudo-distr/server/lens-site.xml 8110ab8
tools/scripts/lens-config.sh 8bd9013
tools/scripts/lens-run-class.sh PRE-CREATION
Diff: https://reviews.apache.org/r/29391/diff/
Testing (updated)
-------
- Ran the TestMLRunner
- build and ran the docker script
Thanks,
sharad agarwal
Re: Review Request 29391: Lens-153 Add example execution runner
Posted by sharad agarwal <sh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29391/
-----------------------------------------------------------
(Updated Dec. 24, 2014, 6:53 a.m.)
Review request for lens, Jaideep dhok and Suma Shivaprasad.
Repository: lens
Description
-------
Lens-153 Add example execution runner
Diffs
-----
lens-client-dist/src/main/assembly/client-dist.xml 8190720
lens-docker/lens-test/Dockerfile f35c0ff
lens-docker/lens-test/lens-bootstrap.sh 23ed307
lens-ml-dist/LICENSE.txt PRE-CREATION
lens-ml-dist/pom.xml PRE-CREATION
lens-ml-dist/src/main/assembly/ml-dist.xml PRE-CREATION
lens-ml-dist/src/site/apt/index.apt PRE-CREATION
lens-ml-lib/data/naive_bayes/ml.properties PRE-CREATION
lens-ml-lib/data/naive_bayes/naive_bayes_train.data dfb9ccd
lens-ml-lib/data/naive_bayes/test.data PRE-CREATION
lens-ml-lib/data/naive_bayes/train.data PRE-CREATION
lens-ml-lib/src/main/java/org/apache/lens/client/LensMLClient.java 5c5bc65
lens-ml-lib/src/main/java/org/apache/lens/ml/MLRunner.java PRE-CREATION
lens-ml-lib/src/main/java/org/apache/lens/ml/task/MLTask.java d2bed0a
lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLResource.java d1318fc
lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLRunner.java PRE-CREATION
lens-ml-lib/tools/scripts/lens-ml-classpath.sh PRE-CREATION
pom.xml 9265a77
tools/conf-pseudo-distr/client/lens-client-site.xml 706e356
tools/conf-pseudo-distr/server/lens-site.xml 8110ab8
tools/scripts/lens-config.sh 8bd9013
tools/scripts/lens-run-class.sh PRE-CREATION
Diff: https://reviews.apache.org/r/29391/diff/
Testing
-------
Thanks,
sharad agarwal