You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/07/04 19:32:35 UTC
[GitHub] [spark] srowen commented on a change in pull request #31611: [SPARK-34488][CORE] Support task Metrics Distributions and executor Metrics Distributions in the REST API call for a specified stage
srowen commented on a change in pull request #31611:
URL: https://github.com/apache/spark/pull/31611#discussion_r663547041
##########
File path: core/src/main/scala/org/apache/spark/status/api/v1/api.scala
##########
@@ -279,7 +292,9 @@ class StageData private[spark](
val resourceProfileId: Int,
@JsonSerialize(using = classOf[ExecutorMetricsJsonSerializer])
@JsonDeserialize(using = classOf[ExecutorMetricsJsonDeserializer])
- val peakExecutorMetrics: Option[ExecutorMetrics])
+ val peakExecutorMetrics: Option[ExecutorMetrics],
+ val taskMetricsDistributions: Option[TaskMetricDistributions],
+ val executorMetricsDistributions: Option[ExecutorMetricsDistributions])
Review comment:
@AngersZhuuuu is this OK to 'break' as it's it's private[spark]? we just discovered that it was kind of accidentally excluded from a previous change between 3.0 -> 3.1. If so we can just retain the exclusion, just checking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org