You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Maulin Vasavada (Jira)" <ji...@apache.org> on 2023/04/11 00:12:00 UTC
[jira] [Commented] (CASSANDRA-18428) Implement/override equals and hashCode methods in the ServerEncryptionOptions class
[ https://issues.apache.org/jira/browse/CASSANDRA-18428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17710356#comment-17710356 ]
Maulin Vasavada commented on CASSANDRA-18428:
---------------------------------------------
PR: [https://github.com/apache/cassandra/pull/2269]
> Implement/override equals and hashCode methods in the ServerEncryptionOptions class
> -----------------------------------------------------------------------------------
>
> Key: CASSANDRA-18428
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18428
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Maulin Vasavada
> Priority: Normal
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We have {{equals and hashCode}} methods in [EncryptionOptions|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/config/EncryptionOptions.java#L551] object but not (overridden/extended) in [ServerEncryptionOptions.|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/config/EncryptionOptions.java#L600]
> Code is using the EncryptionOptions as the key in the [ConcurrentHashMap|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/security/SSLFactory.java#L84] in the SSLFactory.java. Hence technically we must have a equals/hashCode override in the ServerEncryptionOptions to account for fields that matter additionally (e.g. outbound_keystore/password).
> We discussed this over the cassandra-dev slack channel and it seems agreeable to make this change.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org