You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/06/14 11:48:06 UTC
[GitHub] [dubbo-go] watermelo opened a new pull request #605: Mod: add comments for remoting
watermelo opened a new pull request #605:
URL: https://github.com/apache/dubbo-go/pull/605
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
add comments for remoting
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] flycash merged pull request #605: Mod: add comments for remoting
Posted by GitBox <gi...@apache.org>.
flycash merged pull request #605:
URL: https://github.com/apache/dubbo-go/pull/605
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter commented on pull request #605: Mod: add comments for remoting
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #605:
URL: https://github.com/apache/dubbo-go/pull/605#issuecomment-643756435
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/605?src=pr&el=h1) Report
> Merging [#605](https://codecov.io/gh/apache/dubbo-go/pull/605?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/75ae61ded6491950d7ec1cf408452582122e52f0&el=desc) will **increase** coverage by `0.06%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/605/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/605?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #605 +/- ##
===========================================
+ Coverage 67.21% 67.27% +0.06%
===========================================
Files 188 190 +2
Lines 9852 9917 +65
===========================================
+ Hits 6622 6672 +50
- Misses 2580 2590 +10
- Partials 650 655 +5
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/605?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/605/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `73.13% <ø> (ø)` | |
| [remoting/etcdv3/client.go](https://codecov.io/gh/apache/dubbo-go/pull/605/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZXRjZHYzL2NsaWVudC5nbw==) | `57.80% <ø> (ø)` | |
| [remoting/etcdv3/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/605/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZXRjZHYzL2ZhY2FkZS5nbw==) | `0.00% <ø> (ø)` | |
| [remoting/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/605/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZXRjZHYzL2xpc3RlbmVyLmdv) | `46.49% <ø> (+0.40%)` | :arrow_up: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/605/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `76.25% <ø> (ø)` | |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/605/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `52.83% <ø> (ø)` | |
| [remoting/kubernetes/registry\_controller.go](https://codecov.io/gh/apache/dubbo-go/pull/605/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9yZWdpc3RyeV9jb250cm9sbGVyLmdv) | `55.67% <ø> (ø)` | |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/605/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `78.89% <ø> (ø)` | |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/605/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `68.68% <ø> (ø)` | |
| [remoting/zookeeper/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/605/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2ZhY2FkZS5nbw==) | `70.27% <ø> (ø)` | |
| ... and [11 more](https://codecov.io/gh/apache/dubbo-go/pull/605/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/605?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/605?src=pr&el=footer). Last update [75ae61d...5db2e24](https://codecov.io/gh/apache/dubbo-go/pull/605?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #605: Mod: add comments for remoting
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #605:
URL: https://github.com/apache/dubbo-go/pull/605#issuecomment-643756435
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/605?src=pr&el=h1) Report
> Merging [#605](https://codecov.io/gh/apache/dubbo-go/pull/605?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/75ae61ded6491950d7ec1cf408452582122e52f0&el=desc) will **increase** coverage by `0.16%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/605/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/605?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #605 +/- ##
===========================================
+ Coverage 67.21% 67.37% +0.16%
===========================================
Files 188 190 +2
Lines 9852 9917 +65
===========================================
+ Hits 6622 6682 +60
Misses 2580 2580
- Partials 650 655 +5
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/605?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/605/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `73.13% <ø> (ø)` | |
| [remoting/etcdv3/client.go](https://codecov.io/gh/apache/dubbo-go/pull/605/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZXRjZHYzL2NsaWVudC5nbw==) | `57.80% <ø> (ø)` | |
| [remoting/etcdv3/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/605/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZXRjZHYzL2ZhY2FkZS5nbw==) | `0.00% <ø> (ø)` | |
| [remoting/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/605/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZXRjZHYzL2xpc3RlbmVyLmdv) | `46.49% <ø> (+0.40%)` | :arrow_up: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/605/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `76.25% <ø> (ø)` | |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/605/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `52.83% <ø> (ø)` | |
| [remoting/kubernetes/registry\_controller.go](https://codecov.io/gh/apache/dubbo-go/pull/605/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9yZWdpc3RyeV9jb250cm9sbGVyLmdv) | `55.67% <ø> (ø)` | |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/605/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `78.89% <ø> (ø)` | |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/605/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `68.68% <ø> (ø)` | |
| [remoting/zookeeper/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/605/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2ZhY2FkZS5nbw==) | `70.27% <ø> (ø)` | |
| ... and [12 more](https://codecov.io/gh/apache/dubbo-go/pull/605/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/605?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/605?src=pr&el=footer). Last update [75ae61d...7537535](https://codecov.io/gh/apache/dubbo-go/pull/605?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #605: Mod: add comments for remoting
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #605:
URL: https://github.com/apache/dubbo-go/pull/605#issuecomment-643756435
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/605?src=pr&el=h1) Report
> Merging [#605](https://codecov.io/gh/apache/dubbo-go/pull/605?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/75ae61ded6491950d7ec1cf408452582122e52f0&el=desc) will **increase** coverage by `0.06%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/605/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/605?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #605 +/- ##
===========================================
+ Coverage 67.21% 67.27% +0.06%
===========================================
Files 188 190 +2
Lines 9852 9917 +65
===========================================
+ Hits 6622 6672 +50
- Misses 2580 2590 +10
- Partials 650 655 +5
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/605?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/605/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `73.13% <ø> (ø)` | |
| [remoting/etcdv3/client.go](https://codecov.io/gh/apache/dubbo-go/pull/605/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZXRjZHYzL2NsaWVudC5nbw==) | `57.80% <ø> (ø)` | |
| [remoting/etcdv3/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/605/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZXRjZHYzL2ZhY2FkZS5nbw==) | `0.00% <ø> (ø)` | |
| [remoting/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/605/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZXRjZHYzL2xpc3RlbmVyLmdv) | `46.49% <ø> (+0.40%)` | :arrow_up: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/605/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `76.25% <ø> (ø)` | |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/605/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `52.83% <ø> (ø)` | |
| [remoting/kubernetes/registry\_controller.go](https://codecov.io/gh/apache/dubbo-go/pull/605/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9yZWdpc3RyeV9jb250cm9sbGVyLmdv) | `55.67% <ø> (ø)` | |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/605/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `78.89% <ø> (ø)` | |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/605/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `68.68% <ø> (ø)` | |
| [remoting/zookeeper/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/605/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2ZhY2FkZS5nbw==) | `70.27% <ø> (ø)` | |
| ... and [11 more](https://codecov.io/gh/apache/dubbo-go/pull/605/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/605?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/605?src=pr&el=footer). Last update [75ae61d...7537535](https://codecov.io/gh/apache/dubbo-go/pull/605?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org