You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/08 06:36:53 UTC

[GitHub] [doris] Gabriel39 opened a new pull request, #14928: [Pipeline](select node) Support select node on pipeline engine

Gabriel39 opened a new pull request, #14928:
URL: https://github.com/apache/doris/pull/14928

   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem summary
   
   Describe your changes.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: 
       - [ ] Yes
       - [ ] No
       - [ ] I don't know
   2. Has unit tests been added:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   3. Has document been added or modified:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   4. Does it need to update dependencies:
       - [ ] Yes
       - [ ] No
   5. Are there any changes that cannot be rolled back:
       - [ ] Yes (If Yes, please explain WHY)
       - [ ] No
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] Gabriel39 merged pull request #14928: [Pipeline](select node) Support select node on pipeline engine

Posted by GitBox <gi...@apache.org>.
Gabriel39 merged PR #14928:
URL: https://github.com/apache/doris/pull/14928


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #14928: [Pipeline](select node) Support select node on pipeline engine

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14928:
URL: https://github.com/apache/doris/pull/14928#issuecomment-1343734526

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #14928: [Pipeline](select node) Support select node on pipeline engine

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14928:
URL: https://github.com/apache/doris/pull/14928#issuecomment-1345545216

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #14928: [Pipeline](select node) Support select node on pipeline engine

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14928:
URL: https://github.com/apache/doris/pull/14928#issuecomment-1342297801

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #14928: [Pipeline](select node) Support select node on pipeline engine

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on code in PR #14928:
URL: https://github.com/apache/doris/pull/14928#discussion_r1043074225


##########
be/src/pipeline/exec/operator.h:
##########
@@ -338,22 +346,51 @@
 };
 
 template <typename OperatorBuilderType>
-class DataStateOperator : public Operator<OperatorBuilderType> {
+class SourceOperator : public StreamingOperator<OperatorBuilderType> {
+public:
+    using NodeType =
+            std::remove_pointer_t<decltype(std::declval<OperatorBuilderType>().exec_node())>;
+
+    SourceOperator(OperatorBuilderBase* builder, ExecNode* node)
+            : StreamingOperator<OperatorBuilderType>(builder, node) {};
+
+    ~SourceOperator() override = default;
+
+    std::string get_name() const override { return "SourceOperator"; }
+
+    Status get_block(RuntimeState* state, vectorized::Block* block,
+                     SourceState& source_state) override {
+        SCOPED_TIMER(_runtime_profile->total_time_counter());
+        bool eos = false;
+        RETURN_IF_ERROR(_node->pull(state, block, &eos));
+        source_state = eos ? SourceState::FINISHED : SourceState::DEPEND_ON_SOURCE;
+        return Status::OK();
+    }
+
+    Status finalize(RuntimeState* state) override { return Status::OK(); }
+
+    bool can_read() override { return _node->can_read(); }

Review Comment:
   warning: use of undeclared identifier '_node' [clang-diagnostic-error]
   ```cpp
   K(); }
                                                 ^
   ```
   



##########
be/src/pipeline/exec/operator.h:
##########
@@ -338,22 +346,51 @@
 };
 
 template <typename OperatorBuilderType>
-class DataStateOperator : public Operator<OperatorBuilderType> {
+class SourceOperator : public StreamingOperator<OperatorBuilderType> {
+public:
+    using NodeType =
+            std::remove_pointer_t<decltype(std::declval<OperatorBuilderType>().exec_node())>;
+
+    SourceOperator(OperatorBuilderBase* builder, ExecNode* node)
+            : StreamingOperator<OperatorBuilderType>(builder, node) {};
+
+    ~SourceOperator() override = default;
+
+    std::string get_name() const override { return "SourceOperator"; }
+
+    Status get_block(RuntimeState* state, vectorized::Block* block,
+                     SourceState& source_state) override {
+        SCOPED_TIMER(_runtime_profile->total_time_counter());

Review Comment:
   warning: use of undeclared identifier '_runtime_profile' [clang-diagnostic-error]
   ```cpp
   rride {
                                ^
   ```
   



##########
be/src/pipeline/exec/operator.h:
##########
@@ -338,22 +346,51 @@
 };
 
 template <typename OperatorBuilderType>
-class DataStateOperator : public Operator<OperatorBuilderType> {
+class SourceOperator : public StreamingOperator<OperatorBuilderType> {
+public:
+    using NodeType =
+            std::remove_pointer_t<decltype(std::declval<OperatorBuilderType>().exec_node())>;
+
+    SourceOperator(OperatorBuilderBase* builder, ExecNode* node)
+            : StreamingOperator<OperatorBuilderType>(builder, node) {};
+
+    ~SourceOperator() override = default;
+
+    std::string get_name() const override { return "SourceOperator"; }
+
+    Status get_block(RuntimeState* state, vectorized::Block* block,
+                     SourceState& source_state) override {
+        SCOPED_TIMER(_runtime_profile->total_time_counter());
+        bool eos = false;
+        RETURN_IF_ERROR(_node->pull(state, block, &eos));

Review Comment:
   warning: use of undeclared identifier '_node' [clang-diagnostic-error]
   ```cpp
    false;
                                   ^
   ```
   



##########
be/src/pipeline/exec/operator.h:
##########
@@ -338,22 +346,51 @@ class Operator : public OperatorBase {
 };
 
 template <typename OperatorBuilderType>
-class DataStateOperator : public Operator<OperatorBuilderType> {
+class SourceOperator : public StreamingOperator<OperatorBuilderType> {
+public:
+    using NodeType =
+            std::remove_pointer_t<decltype(std::declval<OperatorBuilderType>().exec_node())>;
+
+    SourceOperator(OperatorBuilderBase* builder, ExecNode* node)
+            : StreamingOperator<OperatorBuilderType>(builder, node) {};
+
+    ~SourceOperator() override = default;
+
+    std::string get_name() const override { return "SourceOperator"; }
+
+    Status get_block(RuntimeState* state, vectorized::Block* block,
+                     SourceState& source_state) override {
+        SCOPED_TIMER(_runtime_profile->total_time_counter());

Review Comment:
   warning: no matching constructor for initialization of 'ScopedTimer<doris::MonotonicStopWatch>' (aka 'ScopedTimer<CustomStopWatch<1>>') [clang-diagnostic-error]
   ```cpp
   rride {
                   ^
   ```
   expanded from here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] HappenLee commented on a diff in pull request #14928: [Pipeline](select node) Support select node on pipeline engine

Posted by GitBox <gi...@apache.org>.
HappenLee commented on code in PR #14928:
URL: https://github.com/apache/doris/pull/14928#discussion_r1043002813


##########
be/src/pipeline/exec/operator.h:
##########
@@ -318,6 +319,10 @@ class Operator : public OperatorBase {
     virtual Status get_block(RuntimeState* state, vectorized::Block* block,
                              SourceState& source_state) override {
         SCOPED_TIMER(_runtime_profile->total_time_counter());
+        if (!is_source()) {

Review Comment:
   ？what the work do here， should get block from `_node` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] HappenLee commented on a diff in pull request #14928: [Pipeline](select node) Support select node on pipeline engine

Posted by GitBox <gi...@apache.org>.
HappenLee commented on code in PR #14928:
URL: https://github.com/apache/doris/pull/14928#discussion_r1043070291


##########
be/src/pipeline/exec/operator.h:
##########
@@ -338,22 +346,51 @@ class Operator : public OperatorBase {
 };
 
 template <typename OperatorBuilderType>
-class DataStateOperator : public Operator<OperatorBuilderType> {
+class SourceOperator : public StreamingOperator<OperatorBuilderType> {
+public:
+    using NodeType =
+            std::remove_pointer_t<decltype(std::declval<OperatorBuilderType>().exec_node())>;
+
+    SourceOperator(OperatorBuilderBase* builder, ExecNode* node)
+            : StreamingOperator<OperatorBuilderType>(builder, node) {};
+
+    ~SourceOperator() override = default;
+
+    std::string get_name() const override { return "SourceOperator"; }
+
+    Status get_block(RuntimeState* state, vectorized::Block* block,
+                     SourceState& source_state) override {
+        SCOPED_TIMER(_runtime_profile->total_time_counter());
+        bool eos = false;
+        RETURN_IF_ERROR(_node->pull(state, block, &eos));
+        source_state = eos ? SourceState::FINISHED : SourceState::DEPEND_ON_SOURCE;
+        return Status::OK();
+    }
+
+    Status finalize(RuntimeState* state) override { return Status::OK(); }

Review Comment:
   Do not need override the method `finalize` and `can_read`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #14928: [Pipeline](select node) Support select node on pipeline engine

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14928:
URL: https://github.com/apache/doris/pull/14928#issuecomment-1345150904

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] hello-stephen commented on pull request #14928: [Pipeline](select node) Support select node on pipeline engine

Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #14928:
URL: https://github.com/apache/doris/pull/14928#issuecomment-1342178106

   TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 34.92 seconds
    load time: 431 seconds
    storage size: 17123356366 Bytes
    https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221208070827_clickbench_pr_60020.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #14928: [Pipeline](select node) Support select node on pipeline engine

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14928:
URL: https://github.com/apache/doris/pull/14928#issuecomment-1342293235

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #14928: [Pipeline](select node) Support select node on pipeline engine

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on code in PR #14928:
URL: https://github.com/apache/doris/pull/14928#discussion_r1044992290


##########
be/src/pipeline/exec/operator.h:
##########
@@ -297,20 +302,22 @@ class DataSinkOperator : public OperatorBase {
  * All operators inherited from Operator will hold a ExecNode inside.
  */
 template <typename OperatorBuilderType>
-class Operator : public OperatorBase {
+class StreamingOperator : public OperatorBase {
 public:
     using NodeType =
             std::remove_pointer_t<decltype(std::declval<OperatorBuilderType>().exec_node())>;
 
-    Operator(OperatorBuilderBase* builder, ExecNode* node)
+    StreamingOperator(OperatorBuilderBase* builder, ExecNode* node)
             : OperatorBase(builder), _node(reinterpret_cast<NodeType*>(node)) {};
 
-    ~Operator() override = default;
+    ~StreamingOperator() override = default;
+
+    std::string get_name() const override { return "StreamingOperator"; }
 
     Status prepare(RuntimeState* state) override {
         _runtime_profile.reset(new RuntimeProfile(_operator_builder->get_name()));
         _node->runtime_profile()->insert_child_head(_runtime_profile.get(), true);

Review Comment:
   warning: member access into incomplete type 'doris::pipeline::StreamingOperator<doris::pipeline::ConstValueOperatorBuilder>::NodeType' (aka 'doris::vectorized::VUnionNode') [clang-diagnostic-error]
   ```cpp
   ;
                  ^
   ```
   **be/src/pipeline/exec/const_value_operator.h:40:** in instantiation of member function 'doris::pipeline::StreamingOperator<doris::pipeline::ConstValueOperatorBuilder>::prepare' requested here
   ```cpp
       ConstValueOperator(OperatorBuilderBase* operator_builder, ExecNode* node)
       ^
   ```
   **be/src/pipeline/exec/const_value_operator.h:23:** forward declaration of 'doris::vectorized::VUnionNode'
   ```cpp
   class VUnionNode;
         ^
   ```
   



##########
be/src/pipeline/exec/operator.h:
##########
@@ -297,20 +302,22 @@
  * All operators inherited from Operator will hold a ExecNode inside.
  */
 template <typename OperatorBuilderType>
-class Operator : public OperatorBase {
+class StreamingOperator : public OperatorBase {
 public:
     using NodeType =
             std::remove_pointer_t<decltype(std::declval<OperatorBuilderType>().exec_node())>;
 
-    Operator(OperatorBuilderBase* builder, ExecNode* node)
+    StreamingOperator(OperatorBuilderBase* builder, ExecNode* node)
             : OperatorBase(builder), _node(reinterpret_cast<NodeType*>(node)) {};
 
-    ~Operator() override = default;
+    ~StreamingOperator() override = default;
+
+    std::string get_name() const override { return "StreamingOperator"; }
 
     Status prepare(RuntimeState* state) override {
         _runtime_profile.reset(new RuntimeProfile(_operator_builder->get_name()));
         _node->runtime_profile()->insert_child_head(_runtime_profile.get(), true);
-        _mem_tracker = std::make_unique<MemTracker>("Operator:" + _runtime_profile->name(),
+        _mem_tracker = std::make_unique<MemTracker>(get_name() + ": " + _runtime_profile->name(),
                                                     _runtime_profile.get());
         _node->increase_ref();

Review Comment:
   warning: member access into incomplete type 'doris::pipeline::StreamingOperator<doris::pipeline::ConstValueOperatorBuilder>::NodeType' (aka 'doris::vectorized::VUnionNode') [clang-diagnostic-error]
   ```cpp
   ;
                  ^
   ```
   **be/src/pipeline/exec/const_value_operator.h:23:** forward declaration of 'doris::vectorized::VUnionNode'
   ```cpp
   class VUnionNode;
         ^
   ```
   



##########
be/src/pipeline/exec/operator.h:
##########
@@ -358,6 +366,29 @@
     NodeType* _node;
 };
 
+template <typename OperatorBuilderType>
+class SourceOperator : public StreamingOperator<OperatorBuilderType> {
+public:
+    using NodeType =
+            std::remove_pointer_t<decltype(std::declval<OperatorBuilderType>().exec_node())>;
+
+    SourceOperator(OperatorBuilderBase* builder, ExecNode* node)
+            : StreamingOperator<OperatorBuilderType>(builder, node) {};
+
+    ~SourceOperator() override = default;
+
+    std::string get_name() const override { return "SourceOperator"; }
+
+    Status get_block(RuntimeState* state, vectorized::Block* block,
+                     SourceState& source_state) override {
+        auto& node = StreamingOperator<OperatorBuilderType>::_node;
+        bool eos = false;
+        RETURN_IF_ERROR(node->pull(state, block, &eos));

Review Comment:
   warning: member access into incomplete type 'doris::pipeline::StreamingOperator<doris::pipeline::ConstValueOperatorBuilder>::NodeType' (aka 'doris::vectorized::VUnionNode') [clang-diagnostic-error]
   ```cpp
   ;
                                 ^
   ```
   **be/src/pipeline/exec/const_value_operator.h:40:** in instantiation of member function 'doris::pipeline::SourceOperator<doris::pipeline::ConstValueOperatorBuilder>::get_block' requested here
   ```cpp
       ConstValueOperator(OperatorBuilderBase* operator_builder, ExecNode* node)
       ^
   ```
   **be/src/pipeline/exec/const_value_operator.h:23:** forward declaration of 'doris::vectorized::VUnionNode'
   ```cpp
   class VUnionNode;
         ^
   ```
   



##########
be/src/pipeline/exec/operator.h:
##########
@@ -339,9 +346,10 @@
     Status get_block(RuntimeState* state, vectorized::Block* block,
                      SourceState& source_state) override {
         SCOPED_TIMER(_runtime_profile->total_time_counter());
+        DCHECK(_child);
+        RETURN_IF_ERROR(_child->get_block(state, block, source_state));
         bool eos = false;
         RETURN_IF_ERROR(_node->pull(state, block, &eos));

Review Comment:
   warning: member access into incomplete type 'doris::pipeline::StreamingOperator<doris::pipeline::ConstValueOperatorBuilder>::NodeType' (aka 'doris::vectorized::VUnionNode') [clang-diagnostic-error]
   ```cpp
   ;
                                  ^
   ```
   **be/src/pipeline/exec/operator.h:377:** in instantiation of member function 'doris::pipeline::StreamingOperator<doris::pipeline::ConstValueOperatorBuilder>::get_block' requested here
   ```cpp
   
         ^
   ```
   **be/src/pipeline/exec/const_value_operator.h:23:** forward declaration of 'doris::vectorized::VUnionNode'
   ```cpp
   class VUnionNode;
         ^
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #14928: [Pipeline](select node) Support select node on pipeline engine

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14928:
URL: https://github.com/apache/doris/pull/14928#issuecomment-1342146350

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #14928: [Pipeline](select node) Support select node on pipeline engine

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14928:
URL: https://github.com/apache/doris/pull/14928#issuecomment-1342239705

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #14928: [Pipeline](select node) Support select node on pipeline engine

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14928:
URL: https://github.com/apache/doris/pull/14928#issuecomment-1345457476

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #14928: [Pipeline](select node) Support select node on pipeline engine

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14928:
URL: https://github.com/apache/doris/pull/14928#issuecomment-1345545206

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #14928: [Pipeline](select node) Support select node on pipeline engine

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14928:
URL: https://github.com/apache/doris/pull/14928#issuecomment-1343712813

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org