You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "raphaelauv (via GitHub)" <gi...@apache.org> on 2023/07/31 21:15:55 UTC
[GitHub] [airflow] raphaelauv opened a new pull request, #32983: doc: local executors - rephrase scheduler process
raphaelauv opened a new pull request, #32983:
URL: https://github.com/apache/airflow/pull/32983
this note is at the end of the page (after the listing of the Remote Executors) let's make it super explicit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a diff in pull request #32983: doc: local executors - rephrase scheduler process
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #32983:
URL: https://github.com/apache/airflow/pull/32983#discussion_r1279998041
##########
docs/apache-airflow/core-concepts/executor/index.rst:
##########
@@ -77,4 +77,4 @@ There are two types of executor - those that run tasks *locally* (inside the ``s
.. note::
- Something that often confuses new users of Airflow is that they don't need to run a separate ``executor`` process. This is because the executor's logic runs *inside* the ``scheduler`` process - if you're running a scheduler, you're running the executor.
+ Something that often confuses new users of Airflow is that they don't need to run a separate ``executor`` process using one of the Local Executors or Remote Executors (because executor's logic runs *inside* the ``scheduler`` process and this logic will run the tasks locally or not depending the executor selected).
Review Comment:
```suggestion
New Airflow users may assume they need to run a separate executor process using one of the Local or Remote Executors. This is not correct since the executor logic runs *inside* the scheduler process, and will run the tasks locally or not depending the executor selected.
```
I needed to read the first part of the sentence several times to understand. Flipping the conditional may be useful…
##########
docs/apache-airflow/core-concepts/executor/index.rst:
##########
@@ -77,4 +77,4 @@ There are two types of executor - those that run tasks *locally* (inside the ``s
.. note::
- Something that often confuses new users of Airflow is that they don't need to run a separate ``executor`` process. This is because the executor's logic runs *inside* the ``scheduler`` process - if you're running a scheduler, you're running the executor.
+ Something that often confuses new users of Airflow is that they don't need to run a separate ``executor`` process using one of the Local Executors or Remote Executors (because executor's logic runs *inside* the ``scheduler`` process and this logic will run the tasks locally or not depending the executor selected).
Review Comment:
```suggestion
New Airflow users may assume they need to run a separate executor process using one of the Local or Remote Executors. This is not correct since the executor logic runs *inside* the scheduler process, and will run the tasks locally or not depending the executor selected.
```
I needed to read the first part of the sentence several times to understand. Flipping the conditional may be useful…
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] raphaelauv commented on a diff in pull request #32983: doc: local executors - rephrase scheduler process
Posted by "raphaelauv (via GitHub)" <gi...@apache.org>.
raphaelauv commented on code in PR #32983:
URL: https://github.com/apache/airflow/pull/32983#discussion_r1280256126
##########
docs/apache-airflow/core-concepts/executor/index.rst:
##########
@@ -77,4 +77,4 @@ There are two types of executor - those that run tasks *locally* (inside the ``s
.. note::
- Something that often confuses new users of Airflow is that they don't need to run a separate ``executor`` process. This is because the executor's logic runs *inside* the ``scheduler`` process - if you're running a scheduler, you're running the executor.
+ Something that often confuses new users of Airflow is that they don't need to run a separate ``executor`` process using one of the Local Executors or Remote Executors (because executor's logic runs *inside* the ``scheduler`` process and this logic will run the tasks locally or not depending the executor selected).
Review Comment:
thanks for the review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #32983: doc: local executors - rephrase scheduler process
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #32983:
URL: https://github.com/apache/airflow/pull/32983#issuecomment-1659248070
> thanks @potiuk for the review , my first rephrase attempt was ambiguous , could you check my second attempt , thanks
Better :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a diff in pull request #32983: doc: local executors - rephrase scheduler process
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #32983:
URL: https://github.com/apache/airflow/pull/32983#discussion_r1279998041
##########
docs/apache-airflow/core-concepts/executor/index.rst:
##########
@@ -77,4 +77,4 @@ There are two types of executor - those that run tasks *locally* (inside the ``s
.. note::
- Something that often confuses new users of Airflow is that they don't need to run a separate ``executor`` process. This is because the executor's logic runs *inside* the ``scheduler`` process - if you're running a scheduler, you're running the executor.
+ Something that often confuses new users of Airflow is that they don't need to run a separate ``executor`` process using one of the Local Executors or Remote Executors (because executor's logic runs *inside* the ``scheduler`` process and this logic will run the tasks locally or not depending the executor selected).
Review Comment:
```suggestion
New Airflow users may assume they need to run a separate executor process using one of the Local or Remote Executors. This is not correct. The executor logic runs *inside* the scheduler process, and will run the tasks locally or not depending the executor selected.
```
I needed to read the first part of the sentence several times to understand. Flipping the conditional may be useful…
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #32983: doc: local executors - rephrase scheduler process
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #32983:
URL: https://github.com/apache/airflow/pull/32983#issuecomment-1659196139
Well. Actualy the docs were right before. All executors - no matter if "remote" or "local" have an internal in-scheduler executor that runs as sub-process. For example this is what communicates and monitors running pods when Kubernetes Executor is used, and this is the process that sends Celery tasks and monitors for their status for CeleryExecutor. So executor process in-scheduler will run independently if it is "local" or "remote" executor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] raphaelauv commented on pull request #32983: doc: local executors - rephrase scheduler process
Posted by "raphaelauv (via GitHub)" <gi...@apache.org>.
raphaelauv commented on PR #32983:
URL: https://github.com/apache/airflow/pull/32983#issuecomment-1659217542
thanks @potiuk for the review , ma first rephrase attempt was ambiguous , could you check my second attempt , thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] raphaelauv commented on pull request #32983: doc: local executors - rephrase scheduler process
Posted by "raphaelauv (via GitHub)" <gi...@apache.org>.
raphaelauv commented on PR #32983:
URL: https://github.com/apache/airflow/pull/32983#issuecomment-1661802814
@uranusjr could you please re-review , thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr merged pull request #32983: doc: local executors - rephrase scheduler process
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr merged PR #32983:
URL: https://github.com/apache/airflow/pull/32983
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org