You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/05/09 22:28:01 UTC

[GitHub] [airflow] gdevanla commented on a change in pull request #8699: Scheduler just checks for task instances in 'running' state in execution.

gdevanla commented on a change in pull request #8699:
URL: https://github.com/apache/airflow/pull/8699#discussion_r422554030



##########
File path: airflow/jobs/scheduler_job.py
##########
@@ -1275,7 +1275,7 @@ def _find_executable_task_instances(self, simple_dag_bag, session=None):
                                       " this task has been reached.", task_instance)
                         continue
 
-                if self.executor.has_task(task_instance):
+                if self.executor.is_task_running(task_instance):

Review comment:
       @ashb Thanks for the comment.
   
   The base_executor.queue_command that is eventually called when this condition is `False` checks to see if the `self.queued_tasks` already has an entry for this task. Therefore, I do not see being added to this queue at this point.
   
   Are there other points in the code you believe this could happen. Could you please point me to those points, if any?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org