You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by jonmeredith <gi...@git.apache.org> on 2018/10/16 19:49:10 UTC
[GitHub] cassandra pull request #285: CASSANDRA-14788 against 2.2
GitHub user jonmeredith opened a pull request:
https://github.com/apache/cassandra/pull/285
CASSANDRA-14788 against 2.2
Rebased/updated PR #274 and retargeted against cassandra-2.2 after changes for CASSANDRA-14713 were merged. There is a follow on patch for cassandra-3.0 that adds back the eclipse warnings to the build step.
This PR
* Refactors the CircleCI config to DRY things up a bit.
* Extends it to add support for generating test coverage reports for combinations of unit tests and dtests.
* Drops coverage reporting on the generated lexer/parser classes to improve report readability.
* Finally upgrades JaCoCo to the current release which should support Java11 if the container is upgraded with it.
(Replaces #274)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jonmeredith/cassandra CASSANDRA-14788-2.2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cassandra/pull/285.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #285
----
commit b7c8b46a05fb3ceeee0f23f2b8570a5ada684ce5
Author: Jon Meredith <jm...@...>
Date: 2018-09-13T22:33:30Z
Upgrade JaCoCo from 0.7.5.201505241946 to 0.8.2
Enables experimental support for Java 11/12.
commit 489c7859b2de39fde117a579f90433841bf58718
Author: Jon Meredith <jm...@...>
Date: 2018-09-21T19:39:43Z
circleci: Added comment header block
commit 469c3be727dd1e6a3655f7080f192e956a8d3f3e
Author: Jon Meredith <jm...@...>
Date: 2018-09-21T19:57:03Z
circleci: Refactor to make more modular
Factored out reusable steps into references, taking inspiration
from https://github.com/circleci/frontend/blob/master/.circleci/config.yml
This is a prelude for adding test coverage rather than copy/pasting
each job in their entirety.
commit a30f8ff575c57a185705a19077228ed8fc168b79
Author: Jon Meredith <jm...@...>
Date: 2018-09-21T19:57:26Z
circleci: Add test coverage jobs and workflows.
commit 753a2e2345e96c6172a1372a50d80ba30a46557b
Author: Jon Meredith <jm...@...>
Date: 2018-09-21T20:01:08Z
circecli: clean whitespace to satisfy yamllint warnings
commit a68cabf3aa08ef2f5103bd65564ed1ebc5552491
Author: Jon Meredith <jm...@...>
Date: 2018-09-23T17:19:30Z
circleci: Omit generated lexer/parser from coverage
The data from it is not particularly helpful and
having it present reduces the impact of the missed
instruction/branches bars in the coverage report.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] cassandra issue #285: CASSANDRA-14788 against 2.2
Posted by jonmeredith <gi...@git.apache.org>.
Github user jonmeredith commented on the issue:
https://github.com/apache/cassandra/pull/285
Not sure how best to make a PR for a future merge of this -> 2.2 -> 3.0, but here's the commit that does it https://github.com/jonmeredith/cassandra/commit/669a8814c620f18da86d349ae11869f8cb2a2c3f
if the conflict isn't fixed during the 2.2 -> 3.0 merge.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org