[GitHub] [pulsar-client-go] wolfstudy commented on a change in pull request #529: add LedgerId,EntryId,BatchIdx,PartitionIdx func for MessageId interface

[GitBox <gi...@apache.org>]

wolfstudy commented on a change in pull request #529:
URL: https://github.com/apache/pulsar-client-go/pull/529#discussion_r642768963



##########
File path: pulsar/impl_message_test.go
##########
@@ -36,6 +35,11 @@ func TestMessageId(t *testing.T) {
 	assert.Equal(t, int32(3), id2.(messageID).batchIdx)
 	assert.Equal(t, int32(4), id2.(messageID).partitionIdx)
 
+	assert.Equal(t, int64(1), id2.LedgerId())
+	assert.Equal(t, int64(2), id2.EntryId())
+	assert.Equal(t, int32(3), id2.BatchIdx())
+	assert.Equal(t, int32(4), id2.PartitionIdx())
+

Review comment:
       Please do not cover the current function in the original test case. Can you add a new test case to cover this feature?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org