You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Radu Cotescu <ra...@apache.org> on 2019/07/24 14:55:44 UTC
[VOTE] Release Apache Sling Content Parser API 2.0.0, Apache Sling
Content Parser JSON 2.0.0, Apache Sling Content Parser XML 2.0.0, Apache
Sling Content Parser XML JCR 2.0.0, Apache Sling Content Parser Test
Utilities 2.0.0
Hi,
We solved 1 issue in these releases:
https://issues.apache.org/jira/browse/SLING/fixforversion/12345735
https://issues.apache.org/jira/browse/SLING/fixforversion/12345850
https://issues.apache.org/jira/browse/SLING/fixforversion/12345851
https://issues.apache.org/jira/browse/SLING/fixforversion/12345852
https://issues.apache.org/jira/browse/SLING/fixforversion/12345947
Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2107/
You can use this UNIX script to download the release and verify the signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
Usage:
sh check_staged_release.sh 2107 /tmp/sling-staging
Please vote to approve this release:
[ ] +1 Approve the release
[ ] 0 Don't care
[ ] -1 Don't release, because ...
This majority vote is open for at least 72 hours.
Regards,
Radu Cotescu
Re: [VOTE] Release Apache Sling Content Parser API 2.0.0, Apache
Sling Content Parser JSON 2.0.0, Apache Sling Content Parser XML 2.0.0,
Apache Sling Content Parser XML JCR 2.0.0, Apache Sling Content Parser Test
Utilities 2.0.0
Posted by Carsten Ziegeler <cz...@apache.org>.
+1
Radu Cotescu wrote
> Hi,
>
> We solved 1 issue in these releases:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12345735
> https://issues.apache.org/jira/browse/SLING/fixforversion/12345850
> https://issues.apache.org/jira/browse/SLING/fixforversion/12345851
> https://issues.apache.org/jira/browse/SLING/fixforversion/12345852
> https://issues.apache.org/jira/browse/SLING/fixforversion/12345947
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2107/
>
> You can use this UNIX script to download the release and verify the signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2107 /tmp/sling-staging
>
> Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ] 0 Don't care
> [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Regards,
> Radu Cotescu
>
--
Carsten Ziegeler
Adobe Research Switzerland
cziegeler@apache.org
Re: [VOTE] Release Apache Sling Content Parser API 2.0.0, Apache
Sling Content Parser JSON 2.0.0, Apache Sling Content Parser XML 2.0.0,
Apache Sling Content Parser XML JCR 2.0.0, Apache Sling Content Parser Test
Utilities 2.0.0
Posted by Radu Cotescu <ra...@apache.org>.
Hi Konrad,
> On 24 Jul 2019, at 18:44, Konrad Windszus <ko...@gmx.de> wrote:
>
> But I don't think it does matter for final classes as you anyhow cannot extend/implement them!
You’re right, it doesn’t. And if I think better you’re also right that a class like this one should have been a provider, had it not been final.
Thanks,
Radu
Re: [VOTE] Release Apache Sling Content Parser API 2.0.0, Apache
Sling Content Parser JSON 2.0.0, Apache Sling Content Parser XML 2.0.0,
Apache Sling Content Parser XML JCR 2.0.0, Apache Sling Content Parser Test
Utilities 2.0.0
Posted by Konrad Windszus <ko...@gmx.de>.
IMHO it is the other way around: If only few/one bundle are supposed to implement the interface rather annotate with ProviderType (compare with https://osgi.org/javadoc/osgi.annotation/7.0.0/org/osgi/annotation/versioning/ProviderType.html <https://osgi.org/javadoc/osgi.annotation/7.0.0/org/osgi/annotation/versioning/ProviderType.html> and https://github.com/apache/sling-org-apache-sling-contentparser-api/blob/master/src/main/java/org/apache/sling/contentparser/api/ParserHelper.java <https://github.com/apache/sling-org-apache-sling-contentparser-api/blob/master/src/main/java/org/apache/sling/contentparser/api/ParserHelper.java>).
But I don't think it does matter for final classes as you anyhow cannot extend/implement them!
Konrad
> On 24. Jul 2019, at 18:40, Radu Cotescu <ra...@apache.org> wrote:
>
> Hi Stefan,
>
>> On 24 Jul 2019, at 18:29, Stefan Seifert <ss...@pro-vision.de> wrote:
>>
>> p.s. i think the annotation in [1] should be @ProviderType, not @ConsumerType - but i think this can be changed in future releases without breaking anything.
>> [1] https://github.com/apache/sling-org-apache-sling-contentparser-api/blob/master/src/main/java/org/apache/sling/contentparser/api/ParserHelper.java <https://github.com/apache/sling-org-apache-sling-contentparser-api/blob/master/src/main/java/org/apache/sling/contentparser/api/ParserHelper.java>
> The class is not supposed to be implemented, so IMO this is a Consumer, right? The ConsumerType is actually the default assumed by most OSGi plugins if I remember correctly, so annotating this final class with ConsumerType was just a pedantic move on my part.
>
> Cheers,
> Radu
Re: [VOTE] Release Apache Sling Content Parser API 2.0.0, Apache
Sling Content Parser JSON 2.0.0, Apache Sling Content Parser XML 2.0.0,
Apache Sling Content Parser XML JCR 2.0.0, Apache Sling Content Parser Test
Utilities 2.0.0
Posted by Radu Cotescu <ra...@apache.org>.
Hi Stefan,
> On 24 Jul 2019, at 18:29, Stefan Seifert <ss...@pro-vision.de> wrote:
>
> p.s. i think the annotation in [1] should be @ProviderType, not @ConsumerType - but i think this can be changed in future releases without breaking anything.
> [1] https://github.com/apache/sling-org-apache-sling-contentparser-api/blob/master/src/main/java/org/apache/sling/contentparser/api/ParserHelper.java <https://github.com/apache/sling-org-apache-sling-contentparser-api/blob/master/src/main/java/org/apache/sling/contentparser/api/ParserHelper.java>
The class is not supposed to be implemented, so IMO this is a Consumer, right? The ConsumerType is actually the default assumed by most OSGi plugins if I remember correctly, so annotating this final class with ConsumerType was just a pedantic move on my part.
Cheers,
Radu
RE: [VOTE] Release Apache Sling Content Parser API 2.0.0, Apache
Sling Content Parser JSON 2.0.0, Apache Sling Content Parser XML 2.0.0,
Apache Sling Content Parser XML JCR 2.0.0, Apache Sling Content Parser Test
Utilities 2.0.0
Posted by Stefan Seifert <ss...@pro-vision.de>.
+1
stefan
p.s. i think the annotation in [1] should be @ProviderType, not @ConsumerType - but i think this can be changed in future releases without breaking anything.
[1] https://github.com/apache/sling-org-apache-sling-contentparser-api/blob/master/src/main/java/org/apache/sling/contentparser/api/ParserHelper.java
>-----Original Message-----
>From: Radu Cotescu [mailto:radu@apache.org]
>Sent: Wednesday, July 24, 2019 4:56 PM
>To: Sling Dev
>Subject: [VOTE] Release Apache Sling Content Parser API 2.0.0, Apache Sling
>Content Parser JSON 2.0.0, Apache Sling Content Parser XML 2.0.0, Apache
>Sling Content Parser XML JCR 2.0.0, Apache Sling Content Parser Test
>Utilities 2.0.0
>
>Hi,
>
>We solved 1 issue in these releases:
>https://issues.apache.org/jira/browse/SLING/fixforversion/12345735
>https://issues.apache.org/jira/browse/SLING/fixforversion/12345850
>https://issues.apache.org/jira/browse/SLING/fixforversion/12345851
>https://issues.apache.org/jira/browse/SLING/fixforversion/12345852
>https://issues.apache.org/jira/browse/SLING/fixforversion/12345947
>
>Staging repository:
>https://repository.apache.org/content/repositories/orgapachesling-2107/
>
>You can use this UNIX script to download the release and verify the
>signatures:
>https://gitbox.apache.org/repos/asf?p=sling-tooling-
>release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
>Usage:
>sh check_staged_release.sh 2107 /tmp/sling-staging
>
>Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ] 0 Don't care
> [ ] -1 Don't release, because ...
>
>This majority vote is open for at least 72 hours.
>
>Regards,
>Radu Cotescu
>
Re: [VOTE] Release Apache Sling Content Parser API 2.0.0, Apache
Sling Content Parser JSON 2.0.0, Apache Sling Content Parser XML 2.0.0,
Apache Sling Content Parser XML JCR 2.0.0, Apache Sling Content Parser Test
Utilities 2.0.0
Posted by Andreas Schaefer <sc...@me.com.INVALID>.
+1 (non-binding)
Cheers - Andy
> On Jul 24, 2019, at 7:55 AM, Radu Cotescu <ra...@apache.org> wrote:
>
> Hi,
>
> We solved 1 issue in these releases:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12345735
> https://issues.apache.org/jira/browse/SLING/fixforversion/12345850
> https://issues.apache.org/jira/browse/SLING/fixforversion/12345851
> https://issues.apache.org/jira/browse/SLING/fixforversion/12345852
> https://issues.apache.org/jira/browse/SLING/fixforversion/12345947
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2107/
>
> You can use this UNIX script to download the release and verify the signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2107 /tmp/sling-staging
>
> Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ] 0 Don't care
> [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Regards,
> Radu Cotescu
>
Re: [VOTE] Release Apache Sling Content Parser API 2.0.0, Apache
Sling Content Parser JSON 2.0.0, Apache Sling Content Parser XML 2.0.0,
Apache Sling Content Parser XML JCR 2.0.0, Apache Sling Content Parser Test
Utilities 2.0.0
Posted by Radu Cotescu <ra...@apache.org>.
+1
> On 24 Jul 2019, at 16:55, Radu Cotescu <ra...@apache.org> wrote:
>
> Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ] 0 Don't care
> [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.