You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by gvramana <gi...@git.apache.org> on 2018/04/20 07:39:16 UTC

[GitHub] carbondata pull request #2177: [CARBONDATA-2360][Non Transactional Table]Ins...

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2177#discussion_r182968973
  
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/NewCarbonDataLoadRDD.scala ---
    @@ -381,8 +381,10 @@ class NewDataFrameLoaderRDD[K, V](
             carbonLoadModel.getTableName + CarbonCommonConstants.UNDERSCORE + theSplit.index
           try {
     
    -        loadMetadataDetails.setPartitionCount(CarbonTablePath.DEPRECATED_PATITION_ID)
    -        loadMetadataDetails.setSegmentStatus(SegmentStatus.SUCCESS)
    +        if (!carbonLoadModel.isCarbonNonTransactionalTable) {
    --- End diff --
    
    this check should not be present, only writing to tablestatus needs to be avoided. All the remaining flow should be same.


---