You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/03/13 17:59:03 UTC
[GitHub] [maven-wrapper] gzm55 opened a new pull request #30: MWRAPPER-59 Inline MavenWrapperDownloader.java into mvnw
gzm55 opened a new pull request #30:
URL: https://github.com/apache/maven-wrapper/pull/30
By inlining a lean version of MavenWrapperDownloader.java into `mnvw` script, we can
- remove the `source` installing type
- avoid reuse an outdated MavenWrapperDownloader.class
- make the downloading part of `mvnw` simpler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] gzm55 commented on pull request #30: [MWRAPPER-59] Inline MavenWrapperDownloader.java into mvnw
Posted by GitBox <gi...@apache.org>.
gzm55 commented on pull request #30:
URL: https://github.com/apache/maven-wrapper/pull/30#issuecomment-1080224147
@slawekjaranowski to save reviewers time, i will close this pr before #33 is decided
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] slawekjaranowski commented on pull request #30: [MWRAPPER-59] Inline MavenWrapperDownloader.java into mvnw
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #30:
URL: https://github.com/apache/maven-wrapper/pull/30#issuecomment-1073034101
You removed test `maven-wrapper-plugin/src/it/projects/type_source/`
How inline downloader are covered by tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] gzm55 closed pull request #30: [MWRAPPER-59] Inline MavenWrapperDownloader.java into mvnw
Posted by GitBox <gi...@apache.org>.
gzm55 closed pull request #30:
URL: https://github.com/apache/maven-wrapper/pull/30
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] gzm55 commented on pull request #30: [MWRAPPER-59] Inline MavenWrapperDownloader.java into mvnw
Posted by GitBox <gi...@apache.org>.
gzm55 commented on pull request #30:
URL: https://github.com/apache/maven-wrapper/pull/30#issuecomment-1073038686
> You removed test `maven-wrapper-plugin/src/it/projects/type_source/` How inline downloader are covered by tests?
the IT for type_source verify that the _plugin_ can download/extract the correct files, then run `./mvnw -v` can:
- produce some logs
- download the maven-wrapper.jar
The verify process do not mock the environment without neither `curl` nor `wget`, so the java source branch is not covered.
The inlined Downloader is very simple than the previous one, and should less likely go wrong. And to test the function of the inlined java source in IT stage, we need hide curl and wget commands before run mvnw; or test in the UT stage, by greping out the java source from the script and run a download task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org