You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by Leah-Anderson <gi...@git.apache.org> on 2017/07/20 23:26:20 UTC
[GitHub] nifi pull request #2026: NIFI-4087 Fix to allow exclusion of filename from t...
GitHub user Leah-Anderson opened a pull request:
https://github.com/apache/nifi/pull/2026
NIFI-4087 Fix to allow exclusion of filename from tika criteria.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [X] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [X] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Leah-Anderson/nifi NIFI-4087
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2026.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2026
----
commit 8666e0cecd0fb81b835e19e32818318a88116cd2
Author: Leah <an...@gmail.com>
Date: 2017-07-20T23:20:54Z
NIFI-4087 Fix to allow exclusion of filename from tika criteria.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #2026: NIFI-4087 Fix to allow exclusion of filename from tika cri...
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/2026
will give this a manual test run soon. For future contributions it is probably easiest if you add commits to your PR rather than force pushing over top at least during the review phase. This makes it easier on the reviewer because they can see the diffs between review/change cycles. At the end the reviewer might ask you to squash/rebase or they can do it for you when they merge.
If you have any questions on that let us know.
Thanks again for contributing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #2026: NIFI-4087 Fix to allow exclusion of filename from tika cri...
Posted by Leah-Anderson <gi...@git.apache.org>.
Github user Leah-Anderson commented on the issue:
https://github.com/apache/nifi/pull/2026
Hi Joe. I can go ahead and push an update to remove the comment line. I do see though that the appveyor build failed but the travis-ci one did not. Looking at the appveyor build it looks like the failure wasn't related to the change. So is that safe to ignore that for now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #2026: NIFI-4087 Fix to allow exclusion of filename from t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2026
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #2026: NIFI-4087 Fix to allow exclusion of filename from t...
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2026#discussion_r128655377
--- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/IdentifyMimeType.java ---
@@ -124,7 +147,7 @@ public void process(final InputStream stream) throws IOException {
TikaInputStream tikaStream = TikaInputStream.get(in);
Metadata metadata = new Metadata();
// Add filename if it exists
--- End diff --
probably makes sense to remove this comment now given that whether it will add it is optional
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #2026: NIFI-4087 Fix to allow exclusion of filename from tika cri...
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/2026
looks like a good idea and good change. I'll let travis-ci do its thing and then take a look a bit later. Thanks for contributing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #2026: NIFI-4087 Fix to allow exclusion of filename from tika cri...
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/2026
yep. if travis is happy on at least one then we're likely in good shape.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #2026: NIFI-4087 Fix to allow exclusion of filename from tika cri...
Posted by Leah-Anderson <gi...@git.apache.org>.
Github user Leah-Anderson commented on the issue:
https://github.com/apache/nifi/pull/2026
OK sounds good. Just let me know if I need to do anything else for this (already pushed an updated commit to remove the comment you mentioned)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---