You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by GitBox <gi...@apache.org> on 2019/01/15 20:49:53 UTC
[GitHub] svarnau commented on issue #1771: [TRAFODION-3242]Do not make again
before MAKE CLEAN
svarnau commented on issue #1771: [TRAFODION-3242]Do not make again before MAKE CLEAN
URL: https://github.com/apache/trafodion/pull/1771#issuecomment-454545920
+0 Personally, I'm not a fan of this change. It breaks makefile protocol and expected behavior, in that it forces removal of files in order to re-build them instead of detecting they are out of date with sources.
I understand that our makefiles are not in particularly good shape of re-building things unnecessarily, so that is why I'm not a -1.
This is an ugly work-around rather than fixing makefiles. But I agree that it is an expedient work-around for some parts of long re-build times.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services