[GitHub] [shardingsphere] KSMASTERS commented on a change in pull request #10486: Optimize java doc in ShardingRule class

[GitBox <gi...@apache.org>]

KSMASTERS commented on a change in pull request #10486:
URL: https://github.com/apache/shardingsphere/pull/10486#discussion_r639577749



##########
File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-common/src/main/java/org/apache/shardingsphere/sharding/rule/ShardingRule.java
##########
@@ -339,18 +339,18 @@ public boolean tableRuleExists(final Collection<String> logicTableNames) {
      * Judge if single table rule exists or not.
      *
      * @param logicTableNames logic table names
-     * @return whether single table rule exists for logic tables
+     * @return whether single table rule exists for logic tables or not
      */
     public boolean singleTableRuleExists(final Collection<String> logicTableNames) {
         return singleTableRules.keySet().stream().anyMatch(logicTableNames::contains);
     }
     
     /**
-     * Judge is sharding column or not.
+     * Judge if a column is sharding column or not.

Review comment:
       It seems that I have been unable to append the commit again on the original basis, I modified the local code and did not add another branch to do other work, so the append commit again did not record




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org